Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use CustomMarshaller entry point type #71398

Merged
merged 6 commits into from
Jun 28, 2022

Conversation

elinor-fung
Copy link
Member

Mostly @AaronRobinsonMSFT's work.

Switch to the new proposal with CustomMarshallerAttribute and Scenario enum for the entry point.

Fair bit of cleanup/TODOs to address after this, but I'd rather get the basic model in, since other work will build on it.

@elinor-fung elinor-fung added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Mostly @AaronRobinsonMSFT's work.

Switch to the new proposal with CustomMarshallerAttribute and Scenario enum for the entry point.

Fair bit of cleanup/TODOs to address after this, but I'd rather get the basic model in, since other work will build on it.

Author: elinor-fung
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@ghost ghost assigned elinor-fung Jun 28, 2022
@jkoritzinsky
Copy link
Member

Once this is in, I'll update the tests in #71355.

@elinor-fung elinor-fung merged commit 6c10d0e into dotnet:main Jun 28, 2022
@elinor-fung elinor-fung deleted the customMarshallerAttribute branch June 28, 2022 23:07
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants