Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to PREEMPT mode when calling CoTaskMem* APIs #71031

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Switch to PREEMPT mode when calling CoTaskMem* APIs #71031

merged 3 commits into from
Jun 21, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

Fixes #70973

This enables WinForms to pass.

Still need to consider other COM entry points (for example, ComPreStubWorker).

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone Jun 21, 2022
@jkotas
Copy link
Member

jkotas commented Jun 21, 2022

Still need to consider other COM entry points (for example, ComPreStubWorker).

I think ComPreStubWorker is the only one that needs it. There may be other entrypoints for various corner cases, but I do not think we need to boil the ocean to add this check everywhere.

@AaronRobinsonMSFT
Match Reverse P/Invoke error message style.
9a86d5e 
Add check in ComPreStubWorker().
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review June 21, 2022 03:15
jkotas
jkotas approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AaronRobinsonMSFT
Copy link
Member Author

Failure is #70969.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 786ec9d into dotnet:main Jun 21, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_70973 branch June 21, 2022 15:32
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Jun 22, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-Interop-coreclr
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

cli xUnit tests fail since https://github.com/dotnet/runtime build 20220616.9
2 participants
@AaronRobinsonMSFT @jkotas