JIT: add ability to order blocks in dump by bbNum or bbID #70399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the JIT will dump blocks in bbNext order. This adds other ordering options, specified by `JitDumpFgBlockOrder`: * `0 (default) bbNext` * `1 bbNum` * `2 bbID` `bbID` in particular is useful when comparing JIT dumps where blocks have been reordered but the blocks themselves have similar content.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBy default the JIT will dump blocks in bbNext order. This adds
|
EgorBo
reviewed
Jun 7, 2022
| // | ||
| if (JitConfig.JitDumpFgBlockOrder() == 1) | ||
| { | ||
| jitstd::sort(fgBBOrder->begin(), fgBBOrder->end(), fgBBNumCmp()); |
There was a problem hiding this comment.
nit: probably a more elegant solution is to define a lambda and check mode inside? 🙂
EgorBo
approved these changes
Jun 7, 2022
BruceForstall
approved these changes
Jun 7, 2022
|
Failure is #70231 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the JIT will dump blocks in bbNext order. This adds
other ordering options, specified by
JitDumpFgBlockOrder:0 (default) bbNext1 bbNum2 bbIDbbIDin particular is useful when comparing JIT dumps where blockshave been reordered but the blocks themselves have similar content.