[release/6.0] OpenSslX509ChainProcessor: ignore NotSignatureValid on last element. #70343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #69668 to release/6.0
Fixes: #65874 (comment)
Customer Impact
RHEL9's default crypto policy no longer accepts the use of RSA+SHA1 signatures.
Because .NET uses strict OpenSSL validation, it does not accept certain certificates, which are considered valid by other tools (like
curl
/wget
). This causes websites likehttps://pkgs.dev.azure.com
to no longer be accessible usingHttpClient
on RHEL9.This change relaxes the validation so these certificates are trusted by .NET.
Testing
New tests are included as part of the change.
Risk
Low. The existing tests, combined with the new tests, give confidence to the scoped change. The version in
main
(and the backport) were authored by a Red Hat employee, so we feel that the new RHEL9 scenario has gotten about as good an eye as it could get.