Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UnixFileMode APIs #69980

Merged
merged 42 commits into from
Jun 23, 2022
Merged

Implement UnixFileMode APIs #69980

merged 42 commits into from
Jun 23, 2022

Commits on May 30, 2022

  1. Implement UnixFileMode APIs on Unix.

    @tmds
    tmds committed May 30, 2022
    Configuration menu
    Copy the full SHA
    11c2422 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Throw PNSE on Windows, add UnsupportedOSPlatform.

    @tmds
    tmds committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    b182b4d View commit details
    Browse the repository at this point in the history

  2. Fix API compat issue.

    @tmds
    tmds committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f143499 View commit details
    Browse the repository at this point in the history

  3. Borrow a few things from SafeFileHandle API PR to this compiles.

    @tmds
    tmds committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5138601 View commit details
    Browse the repository at this point in the history

  4. Fix System.IO.FileSystem.AccessControl compilation.

    @tmds
    tmds committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4d6c524 View commit details
    Browse the repository at this point in the history

  5. Add xml docs.

    @tmds
    tmds committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    813e24a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Replace Interop.Sys.Permissions to System.IO.UnixFileMode.

    @tmds
    tmds committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7bd2ae3 View commit details
    Browse the repository at this point in the history

  2. Throw PNSE immediately on Windows.

    @tmds
    tmds committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d67d738 View commit details
    Browse the repository at this point in the history

  3. Add ODE to xml docs of methods that accept a handle.

    @tmds
    tmds committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    3841bfb View commit details
    Browse the repository at this point in the history

  4. Don't throw (PNSE) from FileSystemInfo.UnixFileMode getter on Windows.

    @tmds
    tmds committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d1e7ea8 View commit details
    Browse the repository at this point in the history

  5. Minor style fix.

    @tmds
    tmds committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    f7db626 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Get rid of some casts. 

    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @tmds @eerhardt
    tmds and eerhardt committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    88828a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Add tests for creating a file/directory with UnixFileMode.

    @tmds
    tmds committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    cd4104f View commit details
    Browse the repository at this point in the history

  2. Some CI envs don't have a umask exe, try retrieving via a shell builtin.

    @tmds
    tmds committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c937c28 View commit details
    Browse the repository at this point in the history

  3. Update expected test mode values.

    @tmds
    tmds committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    a12832c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Fix OSX

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d294651 View commit details
    Browse the repository at this point in the history

  2. Fix Windows build.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3df946a View commit details
    Browse the repository at this point in the history

  3. Add ArgumentException tests.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    f3c55bf View commit details
    Browse the repository at this point in the history

  4. Fix Windows build.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    91e0891 View commit details
    Browse the repository at this point in the history

  5. Add get/set tests.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6e74d98 View commit details
    Browse the repository at this point in the history

  6. Update test for Windows.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    757c1e5 View commit details
    Browse the repository at this point in the history

  7. Make setters target link instead of link target.

    @tmds
    tmds committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    53539ec View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Linux: fix SetUnixFileMode

    @tmds
    tmds committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    873660e View commit details
    Browse the repository at this point in the history

  2. Fix OSX compilation.

    @tmds
    tmds committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d9c7789 View commit details
    Browse the repository at this point in the history

  3. Try make all tests pass in CI.

    @tmds
    tmds committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    3dba808 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. For link, operate on target permissions.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    33d3e6f View commit details
    Browse the repository at this point in the history

  2. Skip tests on Browser.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    18e70c9 View commit details
    Browse the repository at this point in the history

  3. Add tests for 'Get' that doesn't use a 'Set' first.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b2423c6 View commit details
    Browse the repository at this point in the history

  4. Don't perform exist check for handles.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    777b77d View commit details
    Browse the repository at this point in the history

  5. Fix Get test for wasm.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    4e93e11 View commit details
    Browse the repository at this point in the history

  6. Review xml comments.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    60d24a7 View commit details
    Browse the repository at this point in the history

  7. Add comment to test.

    @tmds
    tmds committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8f8ff2d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. GetUnixFileMode for handle won't throw UnauthorizedAccessException.

    @tmds
    tmds committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    97df035 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @tmds @eerhardt
    tmds and eerhardt committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7bfa541 View commit details
    Browse the repository at this point in the history

  2. PR feedback.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    01f6ff3 View commit details
    Browse the repository at this point in the history

  3. Update enum doc to say 'owner' instead of 'user'.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    6e91cf1 View commit details
    Browse the repository at this point in the history

  4. Use UnixFileMode in library.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    4cb6316 View commit details
    Browse the repository at this point in the history

  5. Use UnixFileMode in library tests.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7046ea9 View commit details
    Browse the repository at this point in the history

  6. Fix Windows build.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    e55011d View commit details
    Browse the repository at this point in the history

  7. Fix missing FileAccess when changing to FileStreamOptions API.

    @tmds
    tmds committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    bc7383b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. PR feedback.

    @tmds
    tmds committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    d1f043d View commit details
    Browse the repository at this point in the history

  2. Fix Argument_InvalidUnixCreateMode message. 

    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @tmds @adamsitnik
    tmds and adamsitnik committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    168bdf5 View commit details
    Browse the repository at this point in the history