Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update solution files to include missing deps #68668

Merged
merged 1 commit into from
May 2, 2022
Merged

Update solution files to include missing deps #68668

merged 1 commit into from
May 2, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 28, 2022 •
edited
Loading

Fixes #65552
Fixes #67091

@ViktorHofer ViktorHofer added NO-REVIEW Experimental/testing PR, do NOT review it area-Infrastructure-libraries labels Apr 28, 2022
@ViktorHofer ViktorHofer self-assigned this Apr 28, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65552

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

NO-REVIEW, area-Infrastructure-libraries
Milestone: -

@ViktorHofer ViktorHofer mentioned this pull request Apr 28, 2022
Closed
@runfoapp runfoapp bot mentioned this pull request Apr 28, 2022
Closed
@ViktorHofer ViktorHofer mentioned this pull request Apr 29, 2022
Closed
@ViktorHofer ViktorHofer removed the NO-REVIEW Experimental/testing PR, do NOT review it label Apr 29, 2022
@ViktorHofer ViktorHofer requested review from ericstj, joperezr and a team April 29, 2022 12:53
@ViktorHofer ViktorHofer marked this pull request as ready for review April 29, 2022 12:53
@ViktorHofer
Copy link
Member Author

Build failures are unrelated as slns aren't built in CI.

ericstj
ericstj approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks OK to me and I spot checked a few SLNs to confirm the change in size seems minimal.

@ViktorHofer ViktorHofer merged commit 24cabc6 into dotnet:main May 2, 2022
@ViktorHofer ViktorHofer deleted the UpdateSlnsWithClosure branch May 2, 2022 18:14
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

@joperezr joperezr Awaiting requested review from joperezr

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
2 participants
@ViktorHofer @ericstj