Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TestHandleCollector has enough memory pressure to trigger #68652

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Ensure TestHandleCollector has enough memory pressure to trigger #68652

merged 3 commits into from
Apr 29, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

Fixes #66571

/cc @elinor-fung

@AaronRobinsonMSFT AaronRobinsonMSFT added area-System.Runtime.InteropServices test-bug Problem in test source code (most likely) labels Apr 28, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone Apr 28, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66571

/cc @elinor-fung

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices, test-bug
Milestone: 7.0.0

@runfoapp runfoapp bot mentioned this pull request Apr 28, 2022
Closed
elinor-fung
elinor-fung approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it failed, it was always failing on the high limit one - is just that test does the low limit first, so there is enough pressure to warrant collection, but for the high limit, since we just collected, there sometimes isn't enough pressure?

...tem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/HandleCollectorTests.cs Show resolved Hide resolved
@AaronRobinsonMSFT
Copy link
Member Author

When it failed, it was always failing on the high limit one - is just that test does the low limit first, so there is enough pressure to warrant collection, but for the high limit, since we just collected, there sometimes isn't enough pressure?

Exactly. The init will be lower than anything - so it will work. The high just never increases it enough to do anything.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cb10ed9 into dotnet:main Apr 29, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime66571 branch April 29, 2022 00:06
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-System.Runtime.InteropServices test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Test failure System.Runtime.InteropServices.HandleCollectorTests.TestHandleCollector
2 participants
@AaronRobinsonMSFT @elinor-fung