Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation target to avoid losing test coverage with merged test wrappers #66951

Conversation

jkoritzinsky
Copy link
Member

Add a simple validation target to identify when a project has the same assembly name as another project and produce a build-time error.

Contributes to concerns mentioned in #64841

@ghost
Copy link

ghost commented Mar 21, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a simple validation target to identify when a project has the same assembly name as another project and produce a build-time error.

Contributes to concerns mentioned in #64841

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works, LGTM (I'm no msbuild guru here...)

src/tests/Common/mergedrunner.targets Outdated Show resolved Hide resolved
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeremy for providing the first line of defense. For the generated assembly directives, I suspect this is going to be a longer lead project, among others it will require making sure that the generated names don't escape issue exclusions (i.o.w. migrating issues.targets into ActiveIssue clauses is probably a pre-requisite for this transformation). As a first step, a half-pager design plan for this transformation would be super useful.

Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
@jkoritzinsky jkoritzinsky merged commit 65b414c into dotnet:main Mar 22, 2022
@jkoritzinsky jkoritzinsky deleted the projref-rar-validation-merged-test-runner branch March 22, 2022 00:12
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
…wrappers (dotnet#66951)

Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants