-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation target to avoid losing test coverage with merged test wrappers #66951
Add validation target to avoid losing test coverage with merged test wrappers #66951
Conversation
…e assembly name as another project.
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsAdd a simple validation target to identify when a project has the same assembly name as another project and produce a build-time error. Contributes to concerns mentioned in #64841
|
…lict resolution check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it works, LGTM (I'm no msbuild guru here...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jeremy for providing the first line of defense. For the generated assembly directives, I suspect this is going to be a longer lead project, among others it will require making sure that the generated names don't escape issue exclusions (i.o.w. migrating issues.targets into ActiveIssue clauses is probably a pre-requisite for this transformation). As a first step, a half-pager design plan for this transformation would be super useful.
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
…wrappers (dotnet#66951) Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
Add a simple validation target to identify when a project has the same assembly name as another project and produce a build-time error.
Contributes to concerns mentioned in #64841