Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for static virtual methods #66084

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Add support for static virtual methods #66084

merged 1 commit into from
Mar 3, 2022

Commits on Mar 2, 2022

  1. Add support for static virtual methods 

    Took the type system changes from dotnet#54063 and cleaned them up, added unit tests.

Hooked it up into JitInterface/ResolveConstraintMethodApprox. Using the pre-existing `ConstrainedMethodUseLookupResult` that wasn't currently getting emitted. We'll want to use it for its original purpose at some point, but I think we can make this work for both instance and static constrained calls.

Missing things:

* Support creating delegates to static virtual methods. This will need a RyuJIT/JitInterface change.
* Type loader support. If `MakeGeneric` needs static virtuals at runtime, it will throw.

But this is enough to get HttpClient working again. Fixes dotnet#65613. Contributes to dotnet/runtimelab#1665.
    @MichalStrehovsky
    MichalStrehovsky committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    44f9189 View commit details
    Browse the repository at this point in the history