Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure #65322

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure #65322

merged 1 commit into from
Feb 15, 2022

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Feb 14, 2022 •
edited
Loading

Fixes #65279

I removed the SkipTestException check from the EventSource test, letting it delegate to the inner test.

After this and #65105, there is only one other test (EventSource_UnsuccessfulHandshake_LogsStartFailureStop) using an existing test inside RemoteExecutor. But that test doesn't seem like it would ever become flaky / disabled on any OS.

@MihaZupan MihaZupan added this to the 7.0.0 milestone Feb 14, 2022
@MihaZupan MihaZupan requested a review from wfurt February 14, 2022 19:24
@ghost ghost assigned MihaZupan Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65105

I removed the SkipTestException check from the EventSource test, letting it delegate to the inner test.

After this and #65105, there is only one other test (EventSource_UnsuccessfulHandshake_LogsStartFailureStop) using an existing test inside RemoteExecutor. But that test doesn't seem like it would ever become flaky / disabled on any OS.

Author: MihaZupan
Assignees: -
Labels:

area-System.Net.Security
Milestone: 7.0.0

wfurt
wfurt approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan MihaZupan merged commit bc14327 into dotnet:main Feb 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees

@MihaZupan MihaZupan

Labels
area-System.Net.Security
Projects
None yet
Milestone
7.0.0
2 participants
@MihaZupan @wfurt