Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemWatcher.Unix: use CLOEXEC when initializing an inotify instance. #64971

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

tmds
Copy link
Member

@tmds tmds commented Feb 8, 2022

This stops inotify instances from leaking into child processes,
and helps reduce .NET applications hitting the system inotify limit.

@adamsitnik @stephentoub ptal.

…ance.

This stops inotify instances from leaking into child processes,
and helps reduce .NET applications hitting the system inotify limit.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 8, 2022
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ghost
Copy link

ghost commented Feb 8, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This stops inotify instances from leaking into child processes,
and helps reduce .NET applications hitting the system inotify limit.

@adamsitnik @stephentoub ptal.

Author: tmds
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@stephentoub stephentoub added the tenet-reliability Reliability/stability related issue (stress, load problems, etc.) label Feb 8, 2022
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tmds !

@adamsitnik adamsitnik added this to the 7.0.0 milestone Feb 8, 2022
@adamsitnik adamsitnik self-assigned this Feb 8, 2022
@adamsitnik
Copy link
Member

I've re-triggered the OSX CI legs as they have timed out for the 2nd time

@adamsitnik
Copy link
Member

The failures are unrelated (#64964)

@adamsitnik adamsitnik merged commit e48b179 into dotnet:main Feb 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants