Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command-line arguments from Main methods in ILPROJ projects #64482

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

trylek
Copy link
Member

@trylek trylek commented Jan 29, 2022

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).

Thanks

Tomas

/cc @dotnet/jit-contrib

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).

Thanks

Tomas
@ghost
Copy link

ghost commented Jan 29, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

In my recent change I fixed C# test projects to stop using
command-line arguments. This follow-up change complements it by
applying the same transformation to IL projects. In most cases
the arguments were ignored so the transformation was trivial; in
the special case of twoEndFinallys.il the argument array is
passed to the method TwoEndFinallys so I patched it to allocate
a zero-sized string array instead (there are no tests passing
actual command-line arguments to the test app).

Thanks

Tomas

/cc @dotnet/jit-contrib

Author: trylek
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@trylek
Copy link
Member Author

trylek commented Jan 29, 2022

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek
Copy link
Member Author

trylek commented Jan 29, 2022

The one outerloop issue in the new RefField test is known and unrelated to my change that only touches tests under JIT/Methodical, merging in.

@trylek trylek merged commit 77f4d7a into dotnet:main Jan 29, 2022
@trylek trylek deleted the JIT-Methodical-IL-Main-args branch January 29, 2022 07:52
@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants