[release/7.0-preview1] Ensure that we aren't accidentally generating instructions for unsupported ISAs #64224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… AVX2 instructions when not supported
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #64140 to release/7.0-preview1 /cc @tannergooding Customer ImpactTestingRisk
|
echesakov
approved these changes
Jan 24, 2022
|
@tannergooding Were able to run the changes on a device without AVX2? |
Yes and the new assert helps catch the issue even on hardware with AVX2 provided you |
|
cc @jeffschwMSFT for backporting this PR to preview1. |
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Jan 24, 2022
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64140 to release/7.0-preview1
/cc @tannergooding
Customer Impact
Customers running on a machine with AVX but without AVX2 and utilizing certain helper intrinsics will experience a fail fast due to the hardware not supporting the emitted instruction
Testing
An additional assert was added to validate that hardware intrinsics aren't being emitted for unsupported ISAs in codegen. The impacted tests were run with the various
COMPlus_EnableIsa=0switches to validate that the assert was raised before the fix and not after the fix.We have existing outer loop jobs that run the tests with these switches toggled and that will now cause the relevant assert to fire allowing us to catch these issues earlier.
Risk
Minimal. This is the first preview for .NET 7 and the underlying instructions used are already well tested. This was merely an issue around the ISA checks during import handling.