Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stream hash one-shot #64174

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Use Stream hash one-shot #64174

merged 1 commit into from
Jan 24, 2022

Conversation

vcsjones
Copy link
Member

We can use the HashData one-shot here.

There are actually a few more places in S.S.Cryptography.* that could benefit from the one shot, but they are in-flight moving to S.S.Cryptography unified assembly, such as Csp, so I left those alone, for now.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 24, 2022
@ghost
Copy link

ghost commented Jan 24, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

We can use the HashData one-shot here.

There are actually a few more places in S.S.Cryptography.* that could benefit from the one shot, but they are in-flight moving to S.S.Cryptography unified assembly, such as Csp, so I left those alone, for now.

Author: vcsjones
Assignees: -
Labels:

area-System.Security, community-contribution

Milestone: -

@vcsjones
Copy link
Member Author

Failure appears to be #64189.

@bartonjs bartonjs merged commit 2713e11 into dotnet:main Jan 24, 2022
@vcsjones vcsjones deleted the hash-oneshot-use branch January 24, 2022 18:03
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants