Delete GT_SIMD_CHK and GT_HW_INTRINSIC_CHK
#62088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary There are two commits with this change: first just mechanically the opers, leaving for back-compat places where the array checks were treated different as they were. The second commit removes the distinction as it is not a useful one. Since the bounds checks are (no longer) array-only, the remaining oper was renamed to simply
|
SingleAccretion
force-pushed
the
More-Range-Check-Simplification
branch
from
366dd06
to
01de691
Compare
|
@dotnet/jit-contrib |
jakobbotsch
previously approved these changes
Nov 29, 2021
|
Whoops, that approval was meant for #61911. 😄 |
SingleAccretion
force-pushed
the
More-Range-Check-Simplification
branch
from
5ac62d2
to
722f8e0
Compare
The former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary `#ifdef`s.
In loop cloning: redundant with the check for constant lengths below.
In assertion propagation: needless pessimization.
In range check: not needed. While it is not useful to search for the
array lengths from "new int[] { ... }" expressions, it is still useful
to look for assertions related to them.
SingleAccretion
force-pushed
the
More-Range-Check-Simplification
branch
from
722f8e0
to
866b487
Compare
|
@echesakov are you going to review as well? |
echesakov
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary
#ifdefs.There are two commits with this change: first just mechanically deletes the opers, leaving for back-compat places where the array checks were treated differently. The second commit removes the distinction as it is not a useful one.
Since the bounds checks are (no longer) array-only, the remaining oper was renamed to simply
GT_BOUNDS_CHECK.Some diffs from the second commit, in particular the assertion propagation change.