Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all "unmanaged" (no GC fields) sequential types to have sequential layout. #61759

Merged
merged 36 commits into from
Dec 15, 2021
Merged

Change all "unmanaged" (no GC fields) sequential types to have sequential layout. #61759

merged 36 commits into from
Dec 15, 2021

Commits on Nov 18, 2021

  1. Change all "unmanaged" (no GC fields) sequential types to have sequen… 

    …tial layout.
    @jkoritzinsky
    jkoritzinsky committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    3c4ccbc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into managedseqential_unmanaged

    @jkoritzinsky
    jkoritzinsky committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    6b9e41d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Fix inverted condition

    @jkoritzinsky
    jkoritzinsky committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    b85447d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Account for RequiresAlign8 for auto-layout nested structs in sequenti… 

    …al structs in managed-sequential layout
    @jkoritzinsky
    jkoritzinsky committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0ff8540 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Clean up R2R layout algorithm's handling of the new managed-sequentia… 

    …l changes.
    @jkoritzinsky
    jkoritzinsky committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c6ee36d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Update src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRu… 

    …nMetadataFieldLayoutAlgorithm.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    99c0244 View commit details
    Browse the repository at this point in the history

  2. Try to remove the explicit layout quirk by following the behavior in … 

    …all other scenarios (align-up to strictest alignment of members)
    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0ec572a View commit details
    Browse the repository at this point in the history

  3. Fix missed cast.

    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    e2589f3 View commit details
    Browse the repository at this point in the history

  4. Update src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayout… 

    …Algorithm.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @jkoritzinsky @jkotas
    jkoritzinsky and jkotas committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    1744d82 View commit details
    Browse the repository at this point in the history

  5. AlignUp the right variable.

    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    bbaa220 View commit details
    Browse the repository at this point in the history

  6. Remove alignUpInstanceByteSize parameter as it's always true

    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    7afb6d2 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:dotnet/runtime into managedseqentia… 

    …l_unmanaged
    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f8f8390 View commit details
    Browse the repository at this point in the history

  8. Make enums use sequential layout again since the auto-layout algorith… 

    …m calculates alignment based on the required alignment for objects and doesn't allow stricter alignment requirements.
    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0e317fe View commit details
    Browse the repository at this point in the history

  9. Remove HasLayoutMetadata branch and method since the only cases where… 

    … it is true are subsumed by the case on line 2383
    @jkoritzinsky
    jkoritzinsky committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    f174cad View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Handle enum alignment concerns while allowing enums themselves to hav… 

    …e auto layout.
    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6a90bb3 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Update the auto-layout algorithm to better track alignment requiremen… 

    …ts. Fixes dotnet#12977
    @jkoritzinsky
    jkoritzinsky committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    880430a View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Merge branch 'main' of github.com:dotnet/runtime into managedseqentia… 

    …l_unmanaged
    @jkoritzinsky
    jkoritzinsky committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    83e7c80 View commit details
    Browse the repository at this point in the history

  2. Remove now-invalid alignment fixup

    @jkoritzinsky
    jkoritzinsky committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    91df6da View commit details
    Browse the repository at this point in the history

  3. Handle the case of an auto-layout struct as a field in another struct.

    @jkoritzinsky
    jkoritzinsky committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    8196fbe View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Store the custom alignment requirement for layoutkind.auto value type… 

    …s in EEClassOptionalFields and remove our alignment workaround.
    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    da12b83 View commit details
    Browse the repository at this point in the history

  2. Update StructPacking test based on failures.

    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    47c95bf View commit details
    Browse the repository at this point in the history

  3. Fix more of the struct packing test results

    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    c309a69 View commit details
    Browse the repository at this point in the history

  4. Don't double-count the adjustment for auto-layout reference type base… 

    … offsets on x86.
    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    6cfe0c7 View commit details
    Browse the repository at this point in the history

  5. Fix GCSeries calculation for platforms that have the specialized alig… 

    …nment support that kicks in before the ContainsPointers check.
    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    f6af360 View commit details
    Browse the repository at this point in the history

  6. Update check to specifically check if the base size is pointer sized.… 

    … This handles types with an inheritance chain with 0 fields.
    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    66f80e8 View commit details
    Browse the repository at this point in the history

  7. Update StructPacking.cs for arm and arm64 (we now respect alignment r… 

    …equirements in Auto-layout)
    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    8501319 View commit details
    Browse the repository at this point in the history

  8. Fix default packing size calculations

    @jkoritzinsky
    jkoritzinsky committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    1b9eda3 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. Try one more change to fix the last issue

    @jkoritzinsky
    jkoritzinsky committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    2f74ce3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Cleanup and update some corner cases of the managed-sequential case.

    @jkoritzinsky
    jkoritzinsky committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    c98ae95 View commit details
    Browse the repository at this point in the history

  2. Fix nites.

    @jkoritzinsky
    jkoritzinsky committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    966af36 View commit details
    Browse the repository at this point in the history

  3. Fix some copy-paste issues.

    @jkoritzinsky
    jkoritzinsky committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ae9aa6c View commit details
    Browse the repository at this point in the history

  4. Fix ->/. typo

    @jkoritzinsky
    jkoritzinsky committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    842aef2 View commit details
    Browse the repository at this point in the history

  5. Fix disqualifying from managed-sequential when RequiresAlign8 is true… 

    … and the type has GC pointers.
    @jkoritzinsky
    jkoritzinsky committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d269851 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Update x86 tests that check sizeof for types that have changed size.

    @jkoritzinsky
    jkoritzinsky committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e423c3c View commit details
    Browse the repository at this point in the history

  2. Fix Align8 candidate calculation to not account for packing for auto-… 

    …layout.

Update a comment so we aren't confused when looking back here in the future.
    @jkoritzinsky
    jkoritzinsky committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    a1bc86e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'managedseqential_unmanaged' of github.com:jkoritzinsky/… 

    …runtime into managedseqential_unmanaged
    @jkoritzinsky
    jkoritzinsky committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    53e5644 View commit details
    Browse the repository at this point in the history