Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GetPinnableReference() usage in multi-step custom type marshalling #61539

Merged
merged 6 commits into from
Nov 20, 2021
Merged

Update GetPinnableReference() usage in multi-step custom type marshalling #61539

merged 6 commits into from
Nov 20, 2021

Commits on Nov 13, 2021

  1. Update GetPinnableReference() usage in multi-step custom tyep marshal… 

    …ling

Change GetPinnableReference() on a marshaller type to be used as a side effect when marshalling in all cases when a fixed() statement is usable.

Use the Value property getter to get the value to pass to native in all cases.

Update our marshallers and tests to follow this design update.
    @jkoritzinsky
    jkoritzinsky committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    cd0351c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @jkoritzinsky @AaronRobinsonMSFT
    jkoritzinsky and AaronRobinsonMSFT committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    5104216 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Don't emit the assingment to the Value property in the Unmarshal stag… 

    …e when using [Out]
    @jkoritzinsky
    jkoritzinsky committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5eb62da View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Fix the unmarshalling conditions

    @jkoritzinsky
    jkoritzinsky committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    d66549a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Fix Utf16StringMarshaller to correctly handle the "null pointer" case… 

    … now that we're using spans internally for storage in all cases.
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    ada0693 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into getpinnablerefe… 

    …rence-struct-marshalling-design-update
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    5575673 View commit details
    Browse the repository at this point in the history