[mono][llvmonly] Optimize virtual calls/rgctx fetches in gsharedvt methods. #60491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these were all implemented using a slowpath to a JIT icall. Instead, use the normal calling sequence and add a gsharedvt out wrapper at the end if needed.
vargaz
requested review from
EgorBo,
imhameed,
lambdageek and
SamMonoRT
as code owners
* Implement a fastpath for mrgctx fetches. * Load some entries from the gsharedvt info struct instead of doing an rgctx fetch.
vargaz
changed the title
|
@SamMonoRT @lambdageek please review |
imhameed
approved these changes
Oct 19, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these were all implemented using a slowpath to a JIT
icall. Instead, use the normal calling sequence and add a gsharedvt
out wrapper at the end if needed.