Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SkipOn NetFramework attributes in System.Reflection.Emit tests #60103

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 6, 2021

These tests are not run on netfx, so these attributes are just clutter.

These tests are not run on netfx, so these attributes are just clutter.
@ghost
Copy link

ghost commented Oct 6, 2021

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

These tests are not run on netfx, so these attributes are just clutter.

Author: eerhardt
Assignees: -
Labels:

area-System.Reflection.Emit

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether it is worth a grep for SkipOnTargetFramework.*TargetFrameworkMonikers.NetFramework or something in code of our other tests that don't run on .NET Framework.

@danmoseley
Copy link
Member

#60097

@eerhardt
Copy link
Member Author

eerhardt commented Oct 7, 2021

I wonder whether it is worth a grep for SkipOnTargetFramework.*TargetFrameworkMonikers.NetFramework or something in code of our other tests that don't run on .NET Framework.

I can take a look when I get time.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants