Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up a new build of Xunit #60044

Closed
wants to merge 6 commits into from
Closed

Pick up a new build of Xunit #60044

wants to merge 6 commits into from

Commits on Oct 5, 2021

  1. Update to Xunit build 2.4.2-pre.13 

    Also pick up latest pre-release of analyzers
    @ericstj
    ericstj committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    4367e42 View commit details
    Browse the repository at this point in the history

  2. Disambiguate calls to Assert.Equals(double,double,int) 

    Xunit added a new Assert overload that caused a lot of ambiguous calls.
xunit/xunit#2393

Workaround by casting to double.
    @ericstj
    ericstj committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    9f1938d View commit details
    Browse the repository at this point in the history

  3. Fix new instances of xUnit2000 diagnostic

    @ericstj
    ericstj committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    7637493 View commit details
    Browse the repository at this point in the history

  4. Workaround xUnit2002 issue with implicit cast 

    Works around xunit/xunit#2395
    @ericstj
    ericstj committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    a0b9485 View commit details
    Browse the repository at this point in the history

  5. Disable xUnit2014 diagnostic 

    This diagnostic forces the use of Assert.ThrowsAsync for any async method,
however in our case we may want to test that a method will throw
synchronously to avoid regressing that behavior by moving to the async
portion of the method.
    @ericstj
    ericstj committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    63faf78 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Use AssertExtensions to test for null ArgumentException.ParamName 

    Workaround xunit/xunit#2396
    @ericstj
    ericstj committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    39d7874 View commit details
    Browse the repository at this point in the history