Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking SpeechRecognitionEngine Culture to GrammarBuilder test #59516

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Add checking SpeechRecognitionEngine Culture to GrammarBuilder test #59516

merged 2 commits into from
Sep 27, 2021

Conversation

AlexRadch
Copy link
Contributor

Fix #59400 issue.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 23, 2021
@ghost
Copy link

ghost commented Sep 23, 2021

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #59400 issue.

Author: AlexRadch
Assignees: -
Labels:

area-System.Speech
Milestone: -

danmoseley
danmoseley approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works - great. Thanks @AlexRadch

@danmoseley
Copy link
Member

Looks like the test is failing.

@runfoapp runfoapp bot mentioned this pull request Sep 24, 2021
Closed
@danmoseley danmoseley mentioned this pull request Sep 25, 2021
Closed
@danmoseley
Copy link
Member

I have no idea why the exception is not thrown on some configurations. I'd be fine with just skipping the test if rec.RecognizerInfo.Culture != builder.Culture

@danmoseley
Copy link
Member

trying that

@danmoseley danmoseley merged commit 0d05e3e into dotnet:main Sep 27, 2021
@danmoseley
Copy link
Member

thank you !

@AlexRadch AlexRadch deleted the GrammarBuilderTestCulture branch September 28, 2021 02:28
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-System.Speech community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Speech.Tests fail GrammarBuilder test on non-English OS
2 participants
@AlexRadch @danmoseley