Make ParameterDefaultValue.TryGetDefaultValue bitcode compliant #56324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsFixes #47197 cc: @marek-safar
|
safern
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
safern
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
safern
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
eerhardt
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 26, 2021
...dencyInjection.Abstractions/src/Microsoft.Extensions.DependencyInjection.Abstractions.csproj
Show resolved
Hide resolved
eerhardt
reviewed
Jul 26, 2021
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netcoreapp.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jul 26, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
|
ready for another round of review |
eerhardt
reviewed
Jul 27, 2021
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
Outdated
Show resolved
Hide resolved
...dencyInjection.Abstractions/src/Microsoft.Extensions.DependencyInjection.Abstractions.csproj
Outdated
Show resolved
Hide resolved
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netcoreapp.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 27, 2021
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 29, 2021
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
Outdated
Show resolved
Hide resolved
safern
approved these changes
Jul 29, 2021
ViktorHofer
reviewed
Jul 30, 2021
...Microsoft.Extensions.DependencyInjection/src/Microsoft.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jul 30, 2021
stephentoub
reviewed
Jul 30, 2021
Comment on lines
+4
to
+5
| #nullable enable | ||
|
|
There was a problem hiding this comment.
Why are these #nullable enables needed?
There was a problem hiding this comment.
Because the file is shared between 2 projects - one that has been annotated for nullable, and one that hasn't.
…rosoft.Extensions.DependencyInjection.csproj Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
|
Hello @maryamariyan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This was referenced Aug 17, 2021
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50439
cc: @marek-safar