Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.Net.Security Telemetry tests #55910

Merged
3 commits merged into from
Jul 22, 2021
Merged

Conversation

MihaZupan
Copy link
Member

Updated the NetSecurity telemetry tests to use a WaitForEventCounters helper instead of relying on a racy Task.Delay.
Enhanced the test to also check for correct ActivityIds.

Updated the product instrumentation to use a real async method instead of .ContinueWith to ensure events fire under the right ExecutionContext. Similar to the fix in NameResolution from #42188 (#41670 (comment)).

Fixes #42613

@MihaZupan MihaZupan added this to the 6.0.0 milestone Jul 19, 2021
@MihaZupan MihaZupan requested a review from a team July 19, 2021 11:07
@ghost
Copy link

ghost commented Jul 19, 2021

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Updated the NetSecurity telemetry tests to use a WaitForEventCounters helper instead of relying on a racy Task.Delay.
Enhanced the test to also check for correct ActivityIds.

Updated the product instrumentation to use a real async method instead of .ContinueWith to ensure events fire under the right ExecutionContext. Similar to the fix in NameResolution from #42188 (#41670 (comment)).

Fixes #42613

Author: MihaZupan
Assignees: -
Labels:

area-System.Net.Security

Milestone: 6.0.0

@MihaZupan
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karelz
Copy link
Member

karelz commented Jul 22, 2021

@MihaZupan is it ready for re-review from @stephentoub?

@MihaZupan
Copy link
Member Author

Yes. I pushed the change to always return a Task from ProcessAuthenticationAsync as suggested, which should make the logic cleaner.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @MihaZupan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 12c4e4c into dotnet:main Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: System.Net.Security.Tests.TelemetryTest.EventSource_SuccessfulHandshake_LogsStartStop
3 participants