Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property ordering to source gen #55662

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

steveharter
Copy link
Member

Follow up to #55586 for source-gen support.

Original issue: #54748

This orders the property metadata in source gen; no run-time information regarding ordering is passed to STJ at run-time other than the actual list of properties with the correct ordering.

@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up to #55586 for source-gen support.

Original issue: #54748

This orders the property metadata in source gen; no run-time information regarding ordering is passed to STJ at run-time other than the actual list of properties with the correct ordering.

Author: steveharter
Assignees: steveharter
Labels:

area-System.Text.Json

Milestone: 6.0.0

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming clean CI

@ghost
Copy link

ghost commented Jul 14, 2021

Hello @steveharter!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@steveharter
Copy link
Member Author

steveharter commented Jul 14, 2021

Unrelated test failure for Linux x64 Debug:

{
"HelixJobId": "71462bc4-1a07-43cf-94fb-67f0cc675905",
"HelixWorkItemName": "System.Linq.Expressions.Tests"
}


Error message
The Helix Work Item failed. Often this is due to a test crash or infrastructure failure. See the Helix Test Logs tab in the Results page of Azure DevOps.

Assuming #55536

@steveharter steveharter merged commit b412aac into dotnet:main Jul 14, 2021
@steveharter steveharter deleted the PropOrderSrcGen branch July 14, 2021 21:32
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants