DiagnosticsHandler CI testing #55182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
added
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
MihaZupan
force-pushed
the
diag-handler
branch
2 times, most recently
from
76f766f
to
a0debd6
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
`ncurses` port under FreeBSD no longer uses a hashed database but instead uses the more common "directory tree" style. This fixes like 1 failing runtime test for `System.Console`
…otnet#55153) * Handle FileOptions.DeleteOnClose on Unix in SafeFileHandle.Dispose * Move file path into SafeFileHandle on Windows as well Doing so enables cleaning up a bunch of passing around of the file path, while also enabling the path to be fed to more error paths. * Update Net5Compat impl as well
* Revive dotnet#48505 Revive dotnet#48505 and try to find out why the change caused official builds to break. * Use OutputRid when creating .nupkgs, instead of PackageRID Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
* port system.diagnostics.performanceCounter * remvoing custom and private targets hook and remove unused package rferences
…otnet#54883) * Add test * PR feedback Add test covering case where DOTNET_ROOT exists but does not have a dotnet installation on it * Update tests * Use product behavior for test where DOTNET_ROOT exists but has no host * Fix test * Get platform specific extension for hostfxr Use HaveUsedNetRootInstallLocation
…oading. (dotnet#54971) * Optimize mono_dl_build_path for component and Android module loading. mono_dl_build_path probes a lot of variations of paths and in some situations where modules uses platform specific naming, it could try at least two paths before getting to the correct one. This have been a problem for Android a long time since IO is slow on devices, so always failing two probes per module load adds to the startup time on Android. For dynamic component loading the existing schema is particular bad since the scenario of disabling a component means that the component won't exist, and using the existing probing it could do 3 or more load attempts before realize that the component is not present and use the stub implmenentation. Commit splits current mono_dl_build_path probing logic so it can be customized. For components a new function has been added that will always use platform prefix and platform suffixes, and if not found it will stop looking. For most platform that means only one attempt to load a component instead of at least 3, optimize both the scenario when the component is awailable as well as when it should be disabled. Commit also change the default behavior of mono_dl_build_path on Android reversing current schema making it more likely to find modules using platform specific naming, like libMyLibrary.so, in first attempt. It will still fallback using no prefix and default suffix and then the verbatim name to make sure dllimports will still work as before, but favorizing modules using platform specific naming. On all other platforms mono_dl_build_path will continue to keep its current behaviour.
…me (dotnet#54895) * [mono] Don't call Assembly.CodeBase directly in RuntimeAssembly.GetName It's marked as not available in single file apps. Call the underlying get_code_base icall. Fixes dotnet#54835 * [icall] Use MonoImage:filename for RuntimeAssembly.get_code_base For bundled asssemblies in single file scenarios, RuntimeAssembly.CodeBase will be null, matching CoreCLR. * disable codebase test on wasm
* Handle the case where the "notAbandonedWait" event is not signaled
* Enhance the FloatOvfToInt2 test to exercise VN paths It is not very effective right now because the "bad" combinations of types are morphed into helpers too early, but it will be helpful when we enable folding outside of the importer for those cases too. * Enhance the FloatOvfToInt2 test to cover importer It now fails on Windows x86, where many of the previous similar failures were observed. * Disable the test on Mono * Re-enable tests disabled against dotnet#13651 * Re-enable tests disabled against dotnet#51346 * Re-enable tests disabled against dotnet#47374 * Disable folding in gtFoldExprConst * Disable folding in VN * Temporarily promote the test to Pri0 * Reword the comment * Move the tests back to Pri1 Where they originally were.
* Added TimeSpanConverter. * Code review. * Test tweak. * Added invalid cases. * Remove the ToArray call in the case of ValueSequence. * Support escaped strings in TimeSpanConverter. * Removed 'g' format fallback. * Fixed 'h:mm:ss' being accepted by TimeSpanConverter. * Code review. * Code review.
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupan
requested review from
BrzVlad,
eiriktsarpalis,
imhameed,
jozkee,
lambdageek,
layomia,
marek-safar,
naricc,
SamMonoRT,
steveharter,
thaystg and
vargaz
as code owners
|
Sorry everyone that got tagged here - merge triggered code owners for some reason :( |
This was referenced Jul 20, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.