Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H/3 fix cookie test #54825

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

ManickaP
Copy link
Member

Create handler via test helpers instead of directly creating SocketsHttpHandler.

Fixes #54806

@ghost
Copy link

ghost commented Jun 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Create handler via test helpers instead of directly creating SocketsHttpHandler.

Fixes #54806

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

Locally, I'm getting TimeoutException ConnectTimeout_TimesOutSSLAuth_Throws and I see multiple msquic cookie tests failing. I'll disable them individually.

@ManickaP
Copy link
Member Author

I'll leave this parked until #54843 is in.

@ManickaP ManickaP force-pushed the mapichov/h3_fix_cookie_test branch from b6c06ae to 258ac7d Compare June 29, 2021 20:45
@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@ManickaP ManickaP marked this pull request as ready for review June 30, 2021 09:33
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

Failures are unrelated.

@ManickaP ManickaP merged commit f39e721 into dotnet:main Jun 30, 2021
@ManickaP ManickaP deleted the mapichov/h3_fix_cookie_test branch June 30, 2021 11:25
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants