Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we consider buffer length when marshalling back Unicode ByValTStr fields #54695

Merged
merged 6 commits into from
Jun 28, 2021
Merged

Make sure we consider buffer length when marshalling back Unicode ByValTStr fields #54695

merged 6 commits into from
Jun 28, 2021

Commits on Jun 24, 2021

  1. Use string constructor that takes length instead of the one that sear… 

    …ches for a null terminator.

Fixes dotnet#54662
    @jkoritzinsky
    jkoritzinsky committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b6e1d26 View commit details
    Browse the repository at this point in the history

  2. Marshal back buffer size or string to first null terminator, whicheve… 

    …r is shorter
    @jkoritzinsky
    jkoritzinsky committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b85b006 View commit details
    Browse the repository at this point in the history

  3. Add tests.

    @jkoritzinsky
    jkoritzinsky committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    be7408f View commit details
    Browse the repository at this point in the history

  4. Add unicode test.

    @jkoritzinsky
    jkoritzinsky committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    cade968 View commit details
    Browse the repository at this point in the history

  5. Use the same implementation style for the wstr case case as the cstr … 

    …case
    @jkoritzinsky
    jkoritzinsky committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    9515db9 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Fix accidental deletion from test.

    @jkoritzinsky
    jkoritzinsky committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    9c513bf View commit details
    Browse the repository at this point in the history