Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ASAN for CoreCLR #54580

Closed
wants to merge 28 commits into from
Closed

Enable ASAN for CoreCLR #54580

wants to merge 28 commits into from

Conversation

jkoritzinsky
Copy link
Member

Enable AddressSanitizer for CoreCLR Debug and Checked build configurations instead of MSVC RTC1 runtime checks.

Fixes #52131

Contributes to #7066 (gets the infra set up that we can actually explore this)

@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Enable AddressSanitizer for CoreCLR Debug and Checked build configurations instead of MSVC RTC1 runtime checks.

Fixes #52131

Contributes to #7066 (gets the infra set up that we can actually explore this)

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

This was referenced Jun 23, 2021
Closed
Closed
@jkoritzinsky
Copy link
Member Author

Looks like due to the architecture of ASAN, we likely won't be able to run libraries tests until we make the libraries test host use the live-built hosting bits.

@runfoapp runfoapp bot mentioned this pull request Jun 25, 2021
Closed
@jkoritzinsky jkoritzinsky mentioned this pull request Jul 9, 2021
Merged
@runfoapp runfoapp bot mentioned this pull request Jul 15, 2021
Closed
@jaredpar jaredpar mentioned this pull request Aug 17, 2021
Closed
@ghost ghost closed this Aug 29, 2021
@ghost
Copy link

ghost commented Aug 29, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@jkoritzinsky jkoritzinsky reopened this Aug 30, 2021
@jkoritzinsky jkoritzinsky marked this pull request as ready for review August 30, 2021 17:09
@jkoritzinsky
Copy link
Member Author

Reopening as a non-draft to keep the bot from closing it.

@runfoapp runfoapp bot mentioned this pull request Oct 12, 2021
Closed
@jkoritzinsky
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 20, 2021
Closed
Closed
This was referenced Oct 28, 2021
Closed
Closed
This was referenced Mar 21, 2022
Closed
Closed
@jkoritzinsky
Remove TODO
3978425
@jkoritzinsky
ASan is only supported on x86 or x64 of the platforms CoreCLR supports.
7f7289a
@jkoritzinsky
Use the same MSVC runtime option Coreclr-build wide, remove extraneou…
6d70047 
…s flags, and enable VCASAN.
@jkoritzinsky
Remove dac override of CRT flavor. It was causing issues getting VCAs…
aef3ade 
…an to link with the Linux DAC.
@jkoritzinsky
Hack together something horrible to correctly fetch the shadow ranges…
212e6ce 
… to cooperate with the ASAN AV handler.
@jkoritzinsky
Hook up ASAN support lib on Linux using weak symbols instead of dynam…
e2addc9 
…ic entry-point loading.
@jkoritzinsky
Add sanitizers to the single file host.
211f5cd
@jkoritzinsky
Try a few fixes to get the Linux build working again.
d41d8ab
@jkoritzinsky
Disable LeakSanitizer for now to get cleaner test logs.
56da0be
@jkoritzinsky
Add nosanitizer gcinfo build for arm64/arm32 clrjit.
40dfadf
@jkoritzinsky
Only check if an AV is an asan shadow AV in debug since ASAN is debug…
0ea4f85 
…-only
@jkoritzinsky
Disable ASAN in some methods that poke around in parent frames at ret…
df52f72 
…urn addresses and other areas that ASAN doesn't like.
@jkoritzinsky
Let ASAN know when we won't return so it can do some cleanup on the s…
3f8b19d 
…tack.
@jkoritzinsky
Add some ASAN suppressions for x86 and clean up some build script cha…
f4ca4f9 
…nges.
@jkoritzinsky
Use a special type alias to handle differences in how uptr is defined…
f499ba9 
… across platforms.
@jkoritzinsky
Change how StressLogAnalyzer builds temporarily to avoid issues with …
d8576aa 
…linking against ASAN
@jkoritzinsky
Change install for now for consistency with add_executable.
ba7837e
@jkoritzinsky
Fix typo
48e7dfb
@jkoritzinsky
Fix build from rebase
2f60793
@AaronRobinsonMSFT
Copy link
Member

Convert to draft?

@jkoritzinsky
Copy link
Member Author

Yeah I can flip this back to draft. I just don't like when GitHub closes it due to it being a draft.

@jkoritzinsky jkoritzinsky marked this pull request as draft June 22, 2022 20:33
@ghost ghost closed this Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@RobertHenry6bev
Copy link
Contributor

Why was this closed? I'm compiling the runtime with gcc-12 -fsanitize=undefined and uncovering dozens of problems. I would clean up these errors first, then move on to tsan and asan.

@jkoritzinsky
Copy link
Member Author

This is closed because I didn't have time to get back to getting this fully working. I'll try to get the branch cleaned up and a new PR opened.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli left review comments

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable AddressSanitizer on Debug and Checked builds for both MSVC and Clang
4 participants
@jkoritzinsky @AaronRobinsonMSFT @RobertHenry6bev @janvorli