-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Run Wasm.Build.Tests
against workloads
#54451
Commits on Jul 12, 2021
-
[wasm] Emcc.props -> emcc-props.json
.. and use that instead of importing the props file. This allows reading the file on demand, and can be delayed till we have the runtime pack path.
Configuration menu - View commit details
-
Copy full SHA for 880073b - Browse repository at this point
Copy the full SHA 880073bView commit details -
[wasm] Build samples, functional tests, and Wasm.Build.Tests only when
.. needed. - Don't build samples, functional tests, and Wasm.Build.Tests on EAT, AOT lanes - And build the samples in parallel
Configuration menu - View commit details
-
Copy full SHA for c8c6cee - Browse repository at this point
Copy the full SHA c8c6ceeView commit details -
[wasm] Use %(ResolvedRuntimePack.PackageDirectory) to get the runtime
.. pack, instead of constructing it manually from nuget package path.
Configuration menu - View commit details
-
Copy full SHA for f04daf2 - Browse repository at this point
Copy the full SHA f04daf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e23eba - Browse repository at this point
Copy the full SHA 1e23ebaView commit details -
cross-aot: Allow the project to be built directly for packing
- Currently, the cross aot packages get built on CI for the various configs, but we do get the binary built in artifacts. - These changes allow a package to be generated based on that, and it will be useful for installing workloads that use such a package.
Configuration menu - View commit details
-
Copy full SHA for cf11f19 - Browse repository at this point
Copy the full SHA cf11f19View commit details -
Add support for building Wasm.Build.Tests with workloads
Currently we run `Wasm.Build.Tests` on helix, by setting various paths to reference files from `artifacts`. This PR adds another mode, we *try* to test against workload packs. For this: 1. we need the nugets for the various workload packs, and the manifests 2. manifest id, path to those nugets 3. and a SDK version to use for testing Steps: 1. The specified SDK is installed in `artifacts/bin/dotnet-workload` 2. the specified manifest is installed from the built nugets, and any `depends-on` manifests in the json. 3. `dotnet workload install` is used to install the packs, with the built nugets path being used as one the nuget sources Once this setup is done, the tests are run in an environment such that they use `dotnet` from above, and try to resolve packs from there. Known issues: 1. `Pack` target is explicitly invoked for the aotcross projects We still want to test without packs, the case of using `EMSDK_PATH` directly, for example, in the library tests. So, we now run `Wasm.Build.Tests` for Workloads, *and* the regular `EMSDK_PATH`. Two workload specific tests were added in a recent PR (dotnet#54936) - simple test for building blazorwasm template project with AOT - a test to validate that the files in `UnixFilePermissions.xml` for the packs actually exist on disk .. and these are enabled here. Notes: - This also fixes using the correct runtime pack based on the version in the manifest json. - The sdk version is specified with `<SdkVersionForWorkloadTesting>6.0.100-preview.7.21326.4</SdkVersionForWorkloadTesting>` in `eng/Versions.props` TODO: - Run the blazorwasm test with playwright - Add sdk-with-no-packs case also
Configuration menu - View commit details
-
Copy full SHA for c87f5cf - Browse repository at this point
Copy the full SHA c87f5cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa86d41 - Browse repository at this point
Copy the full SHA fa86d41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23c428c - Browse repository at this point
Copy the full SHA 23c428cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7ad91b - Browse repository at this point
Copy the full SHA d7ad91bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fede431 - Browse repository at this point
Copy the full SHA fede431View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2282814 - Browse repository at this point
Copy the full SHA 2282814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f13abc - Browse repository at this point
Copy the full SHA 0f13abcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6532a - Browse repository at this point
Copy the full SHA 0a6532aView commit details -
Configuration menu - View commit details
-
Copy full SHA for df94014 - Browse repository at this point
Copy the full SHA df94014View commit details
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dd92d28 - Browse repository at this point
Copy the full SHA dd92d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d897b8 - Browse repository at this point
Copy the full SHA 5d897b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dbae80 - Browse repository at this point
Copy the full SHA 1dbae80View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc38268 - Browse repository at this point
Copy the full SHA cc38268View commit details -
Configuration menu - View commit details
-
Copy full SHA for 364dc80 - Browse repository at this point
Copy the full SHA 364dc80View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7d8b27 - Browse repository at this point
Copy the full SHA d7d8b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b8a4ae - Browse repository at this point
Copy the full SHA 7b8a4aeView commit details -
lock access to the stringbuilder for output, to prevent it from getti…
…ng corrupted by concurrent access
Configuration menu - View commit details
-
Copy full SHA for 236b644 - Browse repository at this point
Copy the full SHA 236b644View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31d41b9 - Browse repository at this point
Copy the full SHA 31d41b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32fa9c4 - Browse repository at this point
Copy the full SHA 32fa9c4View commit details
Commits on Jul 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b9f99a8 - Browse repository at this point
Copy the full SHA b9f99a8View commit details