Update library testing docs page to reduce confusion #54324

noahfalk · 2021-06-17T12:01:17Z

No description provided.

dotnet-issue-labeler · 2021-06-17T12:01:20Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

docs/workflow/testing/libraries/testing.md

Some example text that seems more clear to me, but only offered as a suggestion. Feel free to adjust it or if you want to use it as-is please double check what I wrote is accurate : ) I think the useful elements are: 1. Being explicit about what workflow steps need to happen in total 2. Being explicit about which commands are covering the entire workflow and which ones are only covering a part of it 3. Show the simple "do-it-all" options first before showing more complex partial options. Glancing at the first example and blindly copying it should land in the pit of success.

docs/workflow/testing/libraries/testing.md

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

docs/workflow/testing/libraries/testing.md

ViktorHofer · 2021-06-23T07:00:29Z

@noahfalk thanks a lot for cleaning the docs up 👍

noahfalk · 2021-06-23T22:04:20Z

@ViktorHofer np! Thanks for answering all the questions and reviewing it : )

…nitial_config * origin/main: (362 commits) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) Move System.Object serialization to ObjectConverter (dotnet#54436) Move setting fHasVirtualStaticMethods out of sanity check section (dotnet#54574) [wasm] Compile .bc->.o in parallel, before passing to the linker (dotnet#54053) Change PathInternal.IsCaseSensitive to a constant (dotnet#54340) Make mono_polling_required a public symbol (dotnet#54592) Respect EventSource::IsSupported setting in more codepaths (dotnet#51977) Root ComActivator for hosting (dotnet#54524) Add ILLink annotations to S.D.Common related to DbConnectionStringBuilder (dotnet#54280) Fix finalizer issue with regions (dotnet#54550) Add support for multi-arch install locations (dotnet#53763) Update library testing docs page to reduce confusion (dotnet#54324) [FileStream] handle UNC and device paths (dotnet#54483) Update NetAnalyzers version (dotnet#54511) Added runtime dependency to fix the intermittent test failures (dotnet#54587) Disable failing System.Reflection.Tests.ModuleTests.GetMethods (dotnet#54564) [wasm] Move AOT builds from `runtime-staging` to `runtime` (dotnet#54577) Keep obj node for ArrayIndex. (dotnet#54584) Disable another failing MemoryCache test (dotnet#54578) ...

Add warning on unmaintained testing doc page

9e49236

noahfalk requested a review from ViktorHofer June 17, 2021 12:01

stephentoub reviewed Jun 17, 2021

View reviewed changes

docs/workflow/testing/libraries/testing.md Outdated Show resolved Hide resolved

ViktorHofer reviewed Jun 18, 2021

View reviewed changes