Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all RandomAccess methods should work for both sync and async file handles #54266

Merged
merged 17 commits into from
Jul 2, 2021
Merged

all RandomAccess methods should work for both sync and async file handles #54266

merged 17 commits into from
Jul 2, 2021

Commits on Jun 16, 2021

  1. all RandomAccess methods should work for both sync and async file han… 

    …dles
    @adamsitnik
    adamsitnik committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    880abcf View commit details
    Browse the repository at this point in the history

  2. use the new RandomAccess APIs and get rid of "GetAwaiter().GetResult()"

    @adamsitnik
    adamsitnik committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    805f105 View commit details
    Browse the repository at this point in the history

  3. make the mixed sync and async IO tests Windows-specific

    @adamsitnik
    adamsitnik committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    2e26b1d View commit details
    Browse the repository at this point in the history

  4. pass the local variable in explicit way

    @adamsitnik
    adamsitnik committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    ffb0f12 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: campersau <buchholz.bastian@googlemail.com>
    @adamsitnik @campersau
    adamsitnik and campersau committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    51f6d1c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into remainingFeedback 

    # Conflicts:
#	src/libraries/System.IO.FileSystem/tests/System.IO.FileSystem.Tests.csproj
    @adamsitnik
    adamsitnik committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    3802047 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. separate implementation for sync and async handles

    @adamsitnik
    adamsitnik committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    518fff8 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. handle lucky path properly: when async operation is executed immediat… 

    …ely and GetLastError() returns SUCCESS instead of PENDING
    @adamsitnik
    adamsitnik committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    44a7440 View commit details
    Browse the repository at this point in the history

  2. remove race condition

    @adamsitnik
    adamsitnik committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    b51dda9 View commit details
    Browse the repository at this point in the history

  3. log last error in case of unexpected return value from Read|WriteFile… 

    … methods
    @adamsitnik
    adamsitnik committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1267d95 View commit details
    Browse the repository at this point in the history

  4. handle case where WriteFile or ReadFille return 1 and LastError retur… 

    …ns ERROR_SUCCESS
    @adamsitnik
    adamsitnik committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    abb4c04 View commit details
    Browse the repository at this point in the history

  5. minor fixes after reading the code again

    @adamsitnik
    adamsitnik committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    eb51b36 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. don't run async file IO tests on Mono on Windows, as it's not supported

    @adamsitnik
    adamsitnik committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    4795fd3 View commit details
    Browse the repository at this point in the history

  2. add missing ()

    @adamsitnik
    adamsitnik committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    90ad6ec View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @adamsitnik @stephentoub
    adamsitnik and stephentoub committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    475b179 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into remainingFeedback

    @adamsitnik
    adamsitnik committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    ce4cb05 View commit details
    Browse the repository at this point in the history

  3. dont run async file IO tests on configs that don't support async file IO

    @adamsitnik
    adamsitnik committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8b15e09 View commit details
    Browse the repository at this point in the history