Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Fix trimming errors for library tests, to help building with AOT #50885

Closed
wants to merge 32 commits into from
Closed

[wasm] Fix trimming errors for library tests, to help building with AOT #50885

wants to merge 32 commits into from

Commits on Apr 22, 2021

  1. [wasm] Fix build errors due to trimming in System.Reflection.Metadata… 

    …LoadContext

The test project explicitly copies, and needs `mscorlib.dll`, which gets
trimmed out with `EnableAggressiveTrimming=true`. Preserve that.
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d108790 View commit details
    Browse the repository at this point in the history

  2. [wasm] Disable broken test System.Data.Tests.XmlDataReaderTest.XmlLoa… 

    …dTest

Tracked in dotnet#51369
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    96766b4 View commit details
    Browse the repository at this point in the history

  3. [wasm] Fix trimming errors for System.ComponentModel.TypeConverter

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e55e78a View commit details
    Browse the repository at this point in the history

  4. [wasm] Reduce verbosity level for debug message

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d751418 View commit details
    Browse the repository at this point in the history

  5. [wasm] Fix trimming errors for System.Runtime.Serialization.Json.Tests 

    .. and System.Runtime.Serialization.Json.ReflectionOnly.Tests

Partially fixes dotnet#50730 .
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ab05604 View commit details
    Browse the repository at this point in the history

  6. [wasm] Fix trimming errors for System.Runtime.Serialization.Xml.Refle… 

    …ctionOnly.Tests

Partially fixes: dotnet#50730
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    72eb51e View commit details
    Browse the repository at this point in the history

  7. Re-enable Serialization tests, from dotnet#50730

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    743f9fe View commit details
    Browse the repository at this point in the history

  8. [wasm] Fix trimming errors for System.Runtime.Caching.Tests 

    Fixes dotnet#50726

```
fail: [FAIL] System.Runtime.Caching.Tests.AdditionalCacheTests.DisposedCacheTest (TaskId:496)
info: System.Configuration.ConfigurationErrorsException : Configuration system failed to initialize (TaskId:496)
info: ---- System.MissingMethodException : No parameterless constructor defined for type 'System.Configuration.ClientConfigurationHost'. (TaskId:496)
info:    at System.Configuration.ConfigurationManager.EnsureConfigurationSystem() in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationManager
info:    at System.Configuration.ConfigurationManager.PrepareConfigSystem() in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationManager.cs:li
info:    at System.Configuration.ConfigurationManager.GetSection(String sectionName) in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationMana
info:    at System.Runtime.Caching.MemoryCacheStatistics.InitializeConfiguration(NameValueCollection config) in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCach
info:    at System.Runtime.Caching.MemoryCacheStatistics..ctor(MemoryCache memoryCache, NameValueCollection config) in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/Mem
info:    at System.Runtime.Caching.MemoryCache.InitDisposableMembers(NameValueCollection config) in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCache.cs:line 20
info:    at System.Runtime.Caching.MemoryCache.Init(NameValueCollection config) in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCache.cs:line 387 (TaskId:496)
info:    at System.Runtime.Caching.MemoryCache..ctor(String name, NameValueCollection config) in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCache.cs:line 355 (
info:    at System.Runtime.Caching.Tests.AdditionalCacheTests.DisposedCacheTest() in /Users/radical/dev/r3/src/libraries/System.Runtime.Caching/tests/AdditionalCacheTests/AdditionalCacheTests.cs:line 16 (Task
info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/sr
info: ----- Inner Stack Trace ----- (TaskId:496)
info:    at System.RuntimeType.CreateInstanceMono(Boolean nonPublic, Boolean wrapExceptions) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src/System/RuntimeType.Mono.cs:line 1525 (TaskId:496)
info:    at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src/System/RuntimeType.Mono.cs:line 1394 (TaskId:4
info:    at System.Activator.CreateInstance(Type type, Boolean nonPublic, Boolean wrapExceptions) in /Users/radical/dev/r3/src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs:line 97 (Tas
info:    at System.Activator.CreateInstance(Type type, Boolean nonPublic) in /Users/radical/dev/r3/src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs:line 87 (TaskId:496)
info:    at System.Configuration.TypeUtil.CreateInstance(Type type) in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/TypeUtil.cs:line 147 (TaskId:496)
info:    at System.Configuration.Internal.ConfigSystem.System.Configuration.Internal.IConfigSystem.Init(Type typeConfigHost, Object[] hostInitParams) in /Users/radical/dev/r3/src/libraries/System.Configuratio
info:    at System.Configuration.ClientConfigurationSystem..ctor() in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigurationSystem.cs:line 2
info:    at System.Configuration.ConfigurationManager.EnsureConfigurationSystem() in /Users/radical/dev/r3/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationManager
```
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    9160bcd View commit details
    Browse the repository at this point in the history

  9. [wasm] Reenable tests that are working with EAT now

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    989d1e1 View commit details
    Browse the repository at this point in the history

  10. [wasm] Fix trimming errors for System.Runtime tests 

    Specifically `System.Text.Tests.EncodingTests`.

```
fail: [FAIL] System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByCodePage_WithDisallowedEncoding_Throws(encodingName: "utf-7", codePage: 65000) (TaskId:531)
info: System.ArgumentNullException : Value cannot be null. (Parameter 'method') (TaskId:531)
info:    at Castle.DynamicProxy.Generators.Emitters.SimpleAST.ConstructorInvocationStatement..ctor(ConstructorInfo method, Expression[] args) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.Emitters.CodeBuilders.ConstructorCodeBuilder.InvokeBaseConstructor(ConstructorInfo constructor, ArgumentReference[] arguments) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.InvocationTypeGenerator.CreateConstructor(AbstractTypeEmitter invocation, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.InvocationTypeGenerator.Generate(ClassEmitter class, ProxyGenerationOptions options, INamingScope namingScope) (TaskId:531)
info:    at Castle.DynamicProxy.Contributors.ClassProxyTargetContributor.BuildInvocationType(MetaMethod method, ClassEmitter class, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.Contributors.ClassProxyTargetContributor.GetInvocationType(MetaMethod method, ClassEmitter class, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.Contributors.ClassProxyTargetContributor.GetMethodGenerator(MetaMethod method, ClassEmitter class, ProxyGenerationOptions options, OverrideMethodDelegate overrideMethod) (TaskId:531)
info:    at Castle.DynamicProxy.Contributors.CompositeTypeContributor.ImplementMethod(MetaMethod method, ClassEmitter class, ProxyGenerationOptions options, OverrideMethodDelegate overrideMethod) (TaskId:531)
info:    at Castle.DynamicProxy.Contributors.CompositeTypeContributor.Generate(ClassEmitter class, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.ClassProxyGenerator.GenerateType(String name, Type[] interfaces, INamingScope namingScope) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.ClassProxyGenerator.<>c__DisplayClass1_0.<GenerateCode>b__0(String n, INamingScope s) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.BaseProxyGenerator.<>c__DisplayClass33_0.<ObtainProxyType>b__0(CacheKey _) (TaskId:531)
info:    at Castle.Core.Internal.SynchronizedDictionary`2[[Castle.DynamicProxy.Generators.CacheKey, Castle.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc],[System.Type, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].GetOrAdd(CacheKey key, Func`2 valueFactory) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.BaseProxyGenerator.ObtainProxyType(CacheKey cacheKey, Func`3 factory) (TaskId:531)
info:    at Castle.DynamicProxy.Generators.ClassProxyGenerator.GenerateCode(Type[] interfaces, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.DefaultProxyBuilder.CreateClassProxyType(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.ProxyGenerator.CreateClassProxyType(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options) (TaskId:531)
info:    at Castle.DynamicProxy.ProxyGenerator.CreateClassProxy(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, Object[] constructorArguments, IInterceptor[] interceptors) (TaskId:531)
info:    at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments) (TaskId:531)
info:    at Moq.Mock`1[[System.Text.Encoding, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].InitializeInstance() (TaskId:531)
info:    at Moq.Mock`1[[System.Text.Encoding, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].OnGetObject() (TaskId:531)
info:    at Moq.Mock.get_Object() (TaskId:531)
info:    at Moq.Mock`1[[System.Text.Encoding, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_Object() (TaskId:531)
info:    at System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByCodePage_WithDisallowedEncoding_Throws(String encodingName, Int32 codePage) in /Users/radical/dev/r3/src/libraries/System.Runtime/tests/System/Text/EncodingTests.cs:line 42 (TaskId:531)
info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 378 (TaskId:531)
```
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d3061e1 View commit details
    Browse the repository at this point in the history

  11. [wasm] Fix trimming errors for System.Tests.ActivatorTests 

    ```
fail: [FAIL] System.Tests.ActivatorTests.TestingCreateInstanceObjectHandle(assemblyName: "TestLoadAssembly", type: "PublicClassSample", returnedFullNameType: "PublicClassSample", exceptionType: null, returnNul
info: System.TypeLoadException : Could not load type 'PublicClassSample' from assembly 'TestLoadAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. (TaskId:531)
info:    at System.Reflection.RuntimeAssembly.GetType(String name, Boolean throwOnError, Boolean ignoreCase) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs:li
info:    at System.Activator.CreateInstanceInternal(String assemblyString, String typeName, Boolean ignoreCase, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationA
info:    at System.Activator.CreateInstance(String assemblyName, String typeName) in /Users/radical/dev/r3/src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs:line 45 (TaskId:531)
info:    at System.Tests.ActivatorTests.TestingCreateInstanceObjectHandle(String assemblyName, String type, String returnedFullNameType, Type exceptionType, Boolean returnNull) in /Users/radical/dev/r3/src/lib
info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /Users/radical/dev/r3/src/mono/System.Private.CoreLib/src
```

Fixes dotnet#50981
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    aa5a2d4 View commit details
    Browse the repository at this point in the history

  12. [wasm] Fix trimming errors for Microsoft.Extensions.Logging.Tests 

    .. and:

- Microsoft.Extensions.Configuration.FileExtensions
- Microsoft.Extensions.Configuration
- Microsoft.Extensions.FileProviders.Composite
- Microsoft.Extensions.Logging
- Microsoft.Extensions.Primitives

Fixes dotnet#50709

Example failures:

```
[02:19:11] fail: [FAIL] Microsoft.Extensions.Logging.Test.LoggerFactoryTest.CreateDisposeDisposesInnerServiceProvider
[02:19:11] info: System.ArgumentException : Type Moq.Internals.InterfaceProxy is not valid base type for interface proxy, because it does not have accessible parameterless constructor. Only a non-sealed class with non-private default constructor can be used as base type for interface proxy. Please use some other valid type.
[02:19:11] info:    at Castle.DynamicProxy.Generators.InterfaceProxyWithTargetGenerator.ThrowInvalidBaseType(Type type, String doesNotHaveAccessibleParameterlessConstructor)
[02:19:11] info:    at Castle.DynamicProxy.Generators.InterfaceProxyWithTargetGenerator.EnsureValidBaseType(Type type)
[02:19:11] info:    at Castle.DynamicProxy.Generators.InterfaceProxyWithTargetGenerator.GenerateCode(Type proxyTargetType, Type[] interfaces, ProxyGenerationOptions options)
[02:19:11] info:    at Castle.DynamicProxy.DefaultProxyBuilder.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
[02:19:11] info:    at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
[02:19:11] info:    at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, IInterceptor[] interceptors)
[02:19:11] info:    at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments)
[02:19:11] info:    at Moq.Mock`1[[Microsoft.Extensions.Logging.ILoggerProvider, Microsoft.Extensions.Logging.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].InitializeInstance()
[02:19:11] info:    at Moq.Mock`1[[Microsoft.Extensions.Logging.ILoggerProvider, Microsoft.Extensions.Logging.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].OnGetObject()
[02:19:11] info:    at Moq.Mock.get_Object()
[02:19:11] info:    at Moq.Mock`1[[Microsoft.Extensions.Logging.ILoggerProvider, Microsoft.Extensions.Logging.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]].get_Object()
[02:19:11] info:    at Microsoft.Extensions.Logging.Test.LoggerFactoryTest.<>c__DisplayClass20_0.<CreateDisposeDisposesInnerServiceProvider>b__3(IServiceProvider _)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSiteMain(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.ResolveService(ServiceCallSite callSite, RuntimeResolverContext context, RuntimeResolverLock lockType, ServiceProviderEngineScope serviceProviderEngine)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSite(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, RuntimeResolverContext context)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSiteMain(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.ResolveService(ServiceCallSite callSite, RuntimeResolverContext context, RuntimeResolverLock lockType, ServiceProviderEngineScope serviceProviderEngine)
[02:19:11] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSite(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSiteMain(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.ResolveService(ServiceCallSite callSite, RuntimeResolverContext context, RuntimeResolverLock lockType, ServiceProviderEngineScope serviceProviderEngine)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSite(ServiceCallSite callSite, RuntimeResolverContext argument)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__1(ServiceProviderEngineScope p)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
[02:19:12] info:    at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[ILoggerFactory](IServiceProvider provider)
[02:19:12] info:    at Microsoft.Extensions.Logging.LoggerFactory.Create(Action`1 configure)
[02:19:12] info:    at Microsoft.Extensions.Logging.Test.LoggerFactoryTest.CreateDisposeDisposesInnerServiceProvider()
[02:19:12] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    11c2901 View commit details
    Browse the repository at this point in the history

  13. Merge linker descriptors for Castle, and Moq

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c1cbd0e View commit details
    Browse the repository at this point in the history

  14. [wasm] Fix trimming errors for Microsoft.Extensions.Logging.Test.Trac… 

    …eSourceLoggerTest

```
[03:01:05] fail: [FAIL] Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not(shouldFormatterBeNull: True)
[03:01:05] info: Castle.DynamicProxy.InvalidProxyConstructorArgumentsException : Can not instantiate proxy of class: System.Diagnostics.TraceListener.
[03:01:05] info: Could not find a parameterless constructor.
[03:01:05] info:    at Castle.DynamicProxy.ProxyGenerator.CreateClassProxyInstance(Type proxyType, List`1 proxyArguments, Type classToProxy, Object[] constructorArguments)
[03:01:05] info:    at Castle.DynamicProxy.ProxyGenerator.CreateClassProxy(Type classToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, Object[] constructorArguments, IInterceptor[] interceptors)
[03:01:05] info:    at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments)
[03:01:05] info:    at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].InitializeInstance()
[03:01:05] info:    at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].OnGetObject()
[03:01:05] info:    at Moq.Mock.get_Object()
[03:01:05] info:    at Moq.Mock`1[[System.Diagnostics.TraceListener, System.Diagnostics.TraceSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].get_Object()
[03:01:05] info:    at Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.<>c__DisplayClass2_0.<Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not>b__0(ILoggingBuilder builder)
[03:01:05] info:    at Microsoft.Extensions.DependencyInjection.LoggingServiceCollectionExtensions.AddLogging(IServiceCollection services, Action`1 configure)
[03:01:05] info:    at Microsoft.Extensions.Logging.Test.TestLoggerBuilder.Create(Action`1 configure)
[03:01:05] info:    at Microsoft.Extensions.Logging.Test.TraceSourceLoggerTest.Log_Shoud_Add_Exception_To_Message_Whether_Formatter_Is_Null_Or_Not(Boolean shouldFormatterBeNull)
[03:01:05] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    7c9dca6 View commit details
    Browse the repository at this point in the history

  15. [wasm] Fix trimming errors in System.Xml.RW* tests 

    ```
[02:19:48] info: System.MissingMethodException : Constructor on type 'OLEDB.Test.ModuleCore.XmlInlineDataDiscoverer' not found.
[02:19:48] info:    at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture)
[02:19:48] info:    at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
[02:19:48] info:    at System.Activator.CreateInstance(Type type, Object[] args)
[02:19:48] info:    at DictionaryExtensions.GetOrAdd[Tuple`2,Object](IDictionary`2 dictionary, Tuple`2 key, Func`1 newValue)
```

Fixes dotnet#50723 .
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1d511cf View commit details
    Browse the repository at this point in the history

  16. [wasm] Fix trimming errors for System.Runtime.Serialization.Xml tests 

    dotnet#50720
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    86b2aad View commit details
    Browse the repository at this point in the history

  17. [wasm] Fix trimming errors for System.Xml.XmlSerializer* 

    Partially fixes dotnet#50724
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4547709 View commit details
    Browse the repository at this point in the history

  18. [wasm] Fix trimming errors for System.Reflection.Tests 

    Don't trim `System.Reflection.TestExe`

Fixes dotnet#50713
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    bebd9b9 View commit details
    Browse the repository at this point in the history

  19. [wasm] Fix trimming errors for System.Reflection.Tests 

    `IList` implementation on `ArrayList` was getting trimmed

```
[02:19:20] fail: [FAIL] System.Reflection.Tests.TypeInfoTests.IsAssignable(type: typeof(System.Collections.IList), c: typeof(System.Collections.ArrayList), expected: True)
[02:19:20] info: Assert.Equal() Failure
[02:19:20] info: Expected: True
[02:19:20] info: Actual:   False
[02:19:20] info:    at System.Reflection.Tests.TypeInfoTests.IsAssignable(Type type, Type c, Boolean expected)
[02:19:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```

Partially fixes dotnet#50715
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    85d48fc View commit details
    Browse the repository at this point in the history

  20. [wasm] Fix trimming errors in System.Reflection.Tests 

    ```
02:19:20] fail: [FAIL] System.Reflection.Tests.AssemblyTests.AssemblyGetForwardedTypesLoadFailure
[02:19:20] info: Assert.Throws() Failure
[02:19:20] info: Expected: typeof(System.Reflection.ReflectionTypeLoadException)
[02:19:20] info: Actual:   (No exception was thrown)
[02:19:20] info:    at System.Reflection.Tests.AssemblyTests.AssemblyGetForwardedTypesLoadFailure()
[02:19:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```

The relevant code:

```csharp
Assembly a = typeof(TypeInForwardedAssembly).Assembly;
ReflectionTypeLoadException rle = Assert.Throws<ReflectionTypeLoadException>(() => a.GetForwardedTypes());`
```

This is relying on types forwarded to `UnloadableAssembly`, and
`ForwardedTypesAssembly`, so don't trim those.

Fixes dotnet#50715
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    19c01a0 View commit details
    Browse the repository at this point in the history

  21. [wasm] Fix build

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ff4241f View commit details
    Browse the repository at this point in the history

  22. Fix copying pdbs, and dependent assemblies

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ff0fab9 View commit details
    Browse the repository at this point in the history

  23. [wasm] Fix trimming errors for System.Runtime.Extensions.Tests 

    Dependent assemblies getting trimmed out.

Partially fixes dotnet#50724
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    722d988 View commit details
    Browse the repository at this point in the history

  24. [wasm] DebuggerSupport=true for tests, as many library tests depend o… 

    …n debugger attributes
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    6560bc5 View commit details
    Browse the repository at this point in the history

  25. [wasm] fix build error for System.Reflection.Tests 

    This depends on pdb files, which are included only if
`DebuggerSupport==true`, but that is set to false by default for tests.
Override that for this project.
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    dbfa7ac View commit details
    Browse the repository at this point in the history

  26. [wasm] Rename ILLink.Descriptor.xml -> *Descriptors.xml

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    77781b1 View commit details
    Browse the repository at this point in the history

  27. Cleanup trimmer descriptors for System.ComponentModel.TypeConverter.T… 

    …ests
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e7043c5 View commit details
    Browse the repository at this point in the history

  28. il descriptors cleanup

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e2cdeb0 View commit details
    Browse the repository at this point in the history

  29. [wasm][tests] Fix path to System.Text.Json.Tests for excluding from t… 

    …he test run
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    066cb1e View commit details
    Browse the repository at this point in the history

  30. [wasm] Disable failing test in System.Xml.Xsl.XslCompiledTransformApi… 

    ….Tests
    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    875c07a View commit details
    Browse the repository at this point in the history

  31. Re-enable System.Xml.Xsl.XslCompiledTransformApi.Tests

    @radical
    radical committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e8cb433 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Merge remote-tracking branch 'origin/main' into build-wasm-aot-helix-… 

    …test
    @radical
    radical committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    404ed1f View commit details
    Browse the repository at this point in the history