[crossgen2] Fix memory leak in _corInfoImpls. #49764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes crossgen2 potentially memory leak.
ConditionalWeakTable _corInfoImpls
elements keeps_compilation
reference which keeps reference to whole table_corInfoImpls
. The circular reference together with issue #12255 potentionally leads to memory leak in crossgen2 if that table is created more than once. As example_corInfoImpls
table is created several times in pipeline mode #37411.WeakReference
allows GC to collect the table and prevents the leak.cc @jkotas @davidwrighton @MichalStrehovsky @gbalykov @alpencolt