Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: don't compute edge weights when there's no profile data #45615

Merged

Conversation

AndyAyersMS
Copy link
Member

We don't look edge the weights unless there's profile data, so only compute
edge weights if there is profile data.

Saves a tiny bit on TP (~0.2%).

We don't look edge the weights unless there's profile data, so only compute
edge weights if there is profile data.

Saves a tiny bit on TP (~0.2%).
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 4, 2020
@AndyAyersMS
Copy link
Member Author

@briansull PTAL
cc @dotnet/jit-contrib

No diffs per SPMI, and via jit-diffs for crossgen.

@BruceForstall
Copy link
Member

No diffs per SPMI, and via jit-diffs for crossgen.

We should add crossgen SPMI collection to you wouldn't need to use jit-diffs for that. (It's always been part of the plan.)

Copy link
Contributor

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@AndyAyersMS AndyAyersMS added this to the 6.0.0 milestone Dec 5, 2020
@AndyAyersMS AndyAyersMS merged commit 29325a6 into dotnet:master Dec 5, 2020
@AndyAyersMS AndyAyersMS deleted the SkipEdgeWeightsIfNoProfileData branch December 5, 2020 02:19
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants