Disable System.Xml.Tests.AsyncReaderLateInitTests.InitializationWithUriOnNonAsyncReaderTrows test on Browser WASM due to PNSE #41936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riOnNonAsyncReaderTrows test on Browser WASM due to PNSE
MaximLipnin
requested review from
directhex,
steveisok,
akoeplinger and
mdh1418
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marek-safar
approved these changes
Sep 7, 2020
steveisok
approved these changes
Sep 8, 2020
mdh1418
approved these changes
Sep 8, 2020
directhex
approved these changes
Sep 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Wasm testing in Chromium happening in #40786, yet another occurrence of
typeof(System.PlatformNotSupportedException): Cannot wait on monitors on this runtime.has been uncovered.This PR just disables the failing test using
PlatformDetection.IsThreadingSupportedfeature detection and fixes a typo in the test naming.Fixes #41163.