Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for packaging and other nits #40134

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

ViktorHofer
Copy link
Member

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

docs/coding-guidelines/project-guidelines.md Outdated Show resolved Hide resolved
docs/workflow/building/libraries/README.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jul 30, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

ViktorHofer and others added 2 commits July 30, 2020 15:26
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@ViktorHofer ViktorHofer merged commit b7f809d into dotnet:master Jul 30, 2020
@ViktorHofer ViktorHofer deleted the DocsUpdates branch July 30, 2020 13:29
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
* Update docs for packaging and other nits
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@@ -227,3 +221,17 @@ If you are working on Windows, and use Visual Studio, you can open individual li
For more details about running tests inside Visual Studio, [go here](../../testing/visualstudio.md).

For more about running tests, read the [running tests](../../testing/libraries/testing.md) document.

## Build packages
To build a library's package, simply invoke `dotnet pack` on the src project after you successfully built the .NETCoreApp vertical from root:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer is there a ./build.sh subset for building library packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmds yes there is. libs.packages -- however you would need to pass down an extra parameter.

./build.sh libs.packages -allConfigurations. IIRC you will also need a prebuilt .NETCoreApp vertical from root.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: how to get release configuration packages?
7 participants