Console.Unix: make Console.OpenStandardInput Stream aware of terminal #39192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis |
|
Seems reasonable. Do you think you could also provide a manual test that highlights the functional changes introduced here? |
|
@eiriktsarpalis I've updated the PR based on your feedback. I will still look into adding a manual test. |
tmds
commented
Jul 15, 2020
|
Any progress on this PR? This is a bug, which we should address for 5.0. |
When performing OpenStandardInput against a terminal, perform Reads on a line-by-line basis and perform appropriate processing and echoing.
eiriktsarpalis
force-pushed
the
console_echo
branch
from
b52cd47
to
b723491
Compare
adamsitnik
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
LGTM, thank you @tmds
I have tested it manually and it works as expected. The CI is green, code looks good. Merging and including in 5.0
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing OpenStandardInput against a terminal, perform Reads on a
line-by-line basis and perform appropriate processing and echoing.
Fixes #39008
@eiriktsarpalis @stephentoub ptal