Fix TRACE_GC build #108089
Open
Fix TRACE_GC build #108089
+60
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CI to avoid breaks
…s 64-bit floating point values)
|
Tagging subscribers to this area: @dotnet/gc |
This was referenced Sep 21, 2024
Open
|
thanks for looking into this @jkoritzinsky! can you please explain why the changes to gcDetailedStartMsg breaks stresslog analyzer? I thought the analyzer just used the first field (which I didn't change) to get the gc index and that's all it used from this message? I can just not change it for stresslog, ie,keep the old msg when it's unfortunate how we have this limit for # of args for stress log entries... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow floats to be passed on 64-bit builds.
@Maoni0 in #105545, you added too many arguments to the
gcDetailedStartMsgand passed the 16-arg maximum (which is causing the build to fail). Also, by changing that message, using the StressLogAnalyzer on logs with the old "gcDetailedStartMsg" value (or in the non-BACKGROUND_GC builds) will not recognize GC start/end with the current native StressLogAnalyzer. Can we split the message into two separate messages to fix these issues?