Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-rc2] [browser] Fix custom icu fingerprinting. #108025

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2024

Backport of #108011 to release/9.0-rc2

/cc @ilonatommy

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
introduced: #103755

Testing

Manual tests.

Risk

Low
It touches a rarely-used scenario of loading custom ICU files to the app. It returns earlier without using fingerprinting mapping that does not apply to this scenario - for custom files no mapping is needed. It was tested with blazor and browser apps.

@ilonatommy ilonatommy self-assigned this Sep 19, 2024
@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Sep 19, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

Please get Tactics approval, we are approaching the time to close this branch.

@lewing lewing added the Servicing-consider Issue for next servicing release review label Sep 19, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 19, 2024
@ilonatommy
Copy link
Member

@carlossanlop, I'm not authorized to merge, I got an approval in email. Could you, please take care of merging?

@lewing lewing merged commit 55c018f into release/9.0-rc2 Sep 21, 2024
38 checks passed
@lewing lewing deleted the backport/pr-108011-to-release/9.0-rc2 branch September 21, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants