Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build break in CrossAOT_Mono crossaot builds #106578

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Fix build break in CrossAOT_Mono crossaot builds #106578

merged 1 commit into from
Aug 18, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 17, 2024 •
edited
Loading

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

This was referenced Aug 18, 2024
Closed
Closed
Closed
Closed
@jkotas jkotas marked this pull request as ready for review August 18, 2024 03:38
@jkotas jkotas requested a review from lewing August 18, 2024 03:39
@jkotas jkotas mentioned this pull request Aug 18, 2024
Open
@jkotas jkotas changed the title Workaround for #106521 Fix build break in CrossAOT_Mono crossaot builds Aug 18, 2024
@jkotas jkotas requested review from crgarcia12 and carlossanlop and removed request for crgarcia12 August 18, 2024 16:39
@lewing lewing merged commit 217525a into dotnet:main Aug 18, 2024
146 of 149 checks passed
@jkotas jkotas deleted the issue-106521 branch August 18, 2024 17:24
@jkotas
Copy link
Member Author

jkotas commented Aug 18, 2024

/backport to release/9.0-rc1

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10442494811

@github-actions github-actions bot mentioned this pull request Aug 18, 2024
Merged
4 tasks
@ericstj
Copy link
Member

ericstj commented Aug 19, 2024

Looks good. Thank you @jkotas! @carlossanlop do we need to propose this upstream?

@jkotas
Copy link
Member Author

jkotas commented Aug 19, 2024 •
edited
Loading

libz-ng has #define W <integer constant> and few other similar defines for single letter symbols in one of the headers. The Windows SDK happens to use single letter field and argument names in a few places. This build break was caused by these defines being applied to Windows SDK.

There are a few options for upstream fix:

  • Include system headers before libz-ng ``#define W ...`. (The change in this PR.)
    or
  • Use #defines with more unique names in libz-ng

@filipnavara filipnavara mentioned this pull request Aug 19, 2024
Merged
@AndyAyersMS AndyAyersMS mentioned this pull request Aug 20, 2024
Closed
@jkurdek jkurdek mentioned this pull request Aug 21, 2024
Closed
@matouskozak matouskozak mentioned this pull request Aug 26, 2024
Closed
@LoopedBard3 LoopedBard3 mentioned this pull request Aug 27, 2024
Closed
@matouskozak matouskozak mentioned this pull request Aug 27, 2024
Closed
@jkurdek jkurdek mentioned this pull request Aug 28, 2024
Closed
@am11 am11 mentioned this pull request Aug 28, 2024
Merged
@DrewScoggins DrewScoggins mentioned this pull request Sep 11, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

Assignees

@jkotas jkotas

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @ericstj @lewing