Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU usage tests on mobile platforms #105722

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix CPU usage tests on mobile platforms #105722

merged 3 commits into from
Jul 30, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 30, 2024

Fixes #105322

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 30, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh
Copy link
Member Author

tarekgh commented Jul 30, 2024

/azp run runtime-androidemulator

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh
Copy link
Member Author

tarekgh commented Jul 30, 2024

/azp run runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tarekgh
Copy link
Member Author

tarekgh commented Jul 30, 2024

@matouskozak do you know why the runtime-ioslikesimulator legs get cancelled that fast?

@tarekgh tarekgh added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 30, 2024
@tarekgh tarekgh added this to the 9.0.0 milestone Jul 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

ericstj
ericstj approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Do we need to run additional pipelines to test this? -- n/m I see you did 👍

@tarekgh tarekgh merged commit 9653506 into dotnet:main Jul 30, 2024
97 of 105 checks passed
@matouskozak
Copy link
Member

@matouskozak do you know why the runtime-ioslikesimulator legs get cancelled that fast?

Sorry, didn't manage to check it in time. Looks like the simulator legs ran eventually and the System.Runtime.Extansions.Tests didn't fail, so everything should be good. I'll check the rolling builds and notify here if we encounter more issue.

@tarekgh tarekgh deleted the FixCpuUsageTestsOnMobilePlatforms branch August 6, 2024 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop left review comments

@ericstj ericstj ericstj approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Runtime
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[Apple] New Environment.CpuUsage tests failing on Apple mobile
4 participants
@tarekgh @matouskozak @carlossanlop @ericstj