Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migrate to zlib-ng, part 3: Remove zlib and zlib-intel source code and license mentions" #105284

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

carlossanlop
Copy link
Member

Reverts #104399

Causing a build failure as reported here: #104399 (comment)

Reverting to avoid blocking the snap.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 22, 2024
@carlossanlop carlossanlop self-assigned this Jul 22, 2024
@carlossanlop carlossanlop added area-System.IO.Compression and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 22, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop merged commit 4399da8 into main Jul 22, 2024
14 of 118 checks passed
@carlossanlop carlossanlop deleted the revert-104399-removeOldZlibs branch July 22, 2024 21:58
@AraHaan
Copy link
Member

AraHaan commented Jul 22, 2024

I feel like what the runtime could do is have the .NET parts p/invoke the existing zlib1.dll for windows that is prebuilt so then there is no need for building a System.IO.Compression.Native assembly for it, Also brotli can be in it's own separate native dll as well if it got one for it by default and would help with things too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants