Introducing Environment.CpuUsage #105152

tarekgh · 2024-07-19T16:11:30Z

dotnet-issue-labeler · 2024-07-19T16:11:35Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2024-07-19T16:11:36Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-07-19T16:13:43Z

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

src/libraries/System.Private.CoreLib/src/System/Environment.SunOS.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Linux.cs

src/libraries/Common/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Linux.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

src/libraries/System.Private.CoreLib/src/System/Environment.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Browser.cs

src/libraries/System.Private.CoreLib/src/System/Environment.iOS.cs

src/libraries/System.Private.CoreLib/src/System/Environment.cs

src/libraries/System.Runtime/ref/System.Runtime.cs

...braries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs

src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs

noahfalk

LGTM

tarekgh · 2024-07-21T02:20:13Z

@jkotas @stephentoub now all feedback is addressed, and we have a clean CI run (I am just rerunning now the unrelated failed tests, but everything related to my change is passing). Thanks again for all feedback. I assume we are good to go now.

...braries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs

src/libraries/System.Private.CoreLib/src/System/Environment.UnixOrBrowser.cs

stephentoub · 2024-07-21T15:39:14Z

src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs

+                Assert.True(usage.TotalTime - totalTime < delta);
+
+                Thread.Sleep(100);
+            }


Would any of these tests fail if we had a bug where, for example, we reported 5ms instead as 5us or vice versa?

I am not sure we can be that accurate without writing the tests calling the underlying OS. I tried to look at the Process tests and couldn't find a test doing that either.

dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Jul 19, 2024

dotnet-policy-service bot assigned tarekgh Jul 19, 2024

tarekgh added this to the 9.0.0 milestone Jul 19, 2024

tarekgh added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 19, 2024

AustinWise reviewed Jul 19, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Environment.SunOS.cs Outdated Show resolved Hide resolved

AustinWise reviewed Jul 19, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Environment.Linux.cs Outdated Show resolved Hide resolved