Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the WeakReference targets in static fields, so they are never freed by the GC during test run #105072

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Jul 18, 2024

fixes #104905

Full explanation: #104905 (comment)

@adamsitnik adamsitnik added area-System.Resources binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it labels Jul 18, 2024
@adamsitnik adamsitnik added this to the 9.0.0 milestone Jul 18, 2024
@adamsitnik adamsitnik self-assigned this Jul 18, 2024
@adamsitnik adamsitnik merged commit 7cac50f into dotnet:main Jul 22, 2024
84 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Resources binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Resources.Extensions.Tests.FormattedObject.BasicObjectTests.BasicObjectsRoundTripAndMatch failure
2 participants