Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0][browser] drop old npm dependencies #104359

Conversation

pavelsavara
Copy link
Member

Partial backport of #103639 to release/8.0

  • drop samples with old NPM dependencies
  • fix test script to allow loading latest ws module in NodeJS

Customer Impact

None, this is just to pacify security scanner and only touches non-production code.

Testing

Automated CI

Risk

Low risk.

@pavelsavara pavelsavara added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 3, 2024
@pavelsavara pavelsavara added this to the 8.0.x milestone Jul 3, 2024
@pavelsavara pavelsavara self-assigned this Jul 3, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara changed the title [release/8.0] drop old npm dependencies [release/8.0][browser] drop old npm dependencies Jul 3, 2024
@pavelsavara
Copy link
Member Author

@carlossanlop do we need tactics approval for this ?

@steveisok
Copy link
Member

@carlossanlop do we need tactics approval for this ?

No, for tests and infra it's tell-mode. Just float an email after you merge.

@carlossanlop
Copy link
Member

@pavelsavara friendly reminder that code complete for the August Release is July 15th. If you want this fix to be included in that release, please merge this PR before that date.

If this is a tell-mode / test-only change, we can directly apply the servicing-approved label.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 3, 2024
@pavelsavara pavelsavara merged commit 567ed24 into dotnet:release/8.0-staging Jul 3, 2024
100 of 107 checks passed
@pavelsavara pavelsavara deleted the release_80_staging_npm_packages branch July 3, 2024 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants