-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Transition to 1ES templates work (Backport crossgen2 changes) #101869
[release/8.0-staging] Transition to 1ES templates work (Backport crossgen2 changes) #101869
Conversation
Note regarding the
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…e packs for all possible targets. Use the local targeting and runtime packs explicitly to make sure we're publishing crossgen2 with the local build. Extracted from dotnet#92826
Could you elaborate a bit on what's required here? It's not clear to me why we need crossgen2 changes. |
The crossgen2 changes are needed to avoid the build/restore for publishing crossgen2 while also building it in the repo related to finding host artifacts correctly (there's conflicts around finding hosting artifacts when NativeAOT is supported). The test official build for backporting #92901 exposed these issues, and @eduardo-vp and I feel that backporting the criossgen2 changes will fix those problems. |
Makes sense. I will review to try to ensure that all the pieces we've changed are backported. |
I just checked that the issues exposed in the test official build @jkoritzinsky mentioned are effectively solved by applying these commits (Official build before https://dev.azure.com/dnceng/internal/_build/results?buildId=2445418&view=results and after https://dev.azure.com/dnceng/internal/_build/results?buildId=2448441&view=results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. let's consider this tell mode. please merge when ready
0fdb133
into
dotnet:release/8.0-staging
This is part of the work to transition to the 1ES templates in servicing branches.
These crossgen2 changes are required to eventually backport #92901.
Official build (64c851b): https://dev.azure.com/dnceng/internal/_build/results?buildId=2447759&view=results
cc @jkoritzinsky @agocke @amanasifkhalid