Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] deadlock in BrowserWebSocket when used from multiple threads #96173

Closed
pavelsavara opened this issue Dec 19, 2023 · 2 comments · Fixed by #95370 or #96618
Closed

[browser][MT] deadlock in BrowserWebSocket when used from multiple threads #96173

pavelsavara opened this issue Dec 19, 2023 · 2 comments · Fixed by #95370 or #96618
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@pavelsavara
Copy link
Member

System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ExpectedStates
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 19, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Dec 19, 2023
@pavelsavara pavelsavara self-assigned this Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ExpectedStates

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara mentioned this issue Dec 19, 2023
Closed
31 tasks
@pavelsavara
Copy link
Member Author

This is caused by making synchronous calls to JS interop with the BrowserWebSocket._thisLock locked on multiple threads

@pavelsavara pavelsavara changed the title [browser][MT] deadlock in CloseTest.CloseOutputAsync_ExpectedStates [browser][MT] deadlock in BrowserWebSocket when used from multiple threads Dec 19, 2023
pavelsavara added a commit to pavelsavara/runtime that referenced this issue Dec 19, 2023
@pavelsavara
feedback
9b8e3ad 
cancellation thread safe
Active issue dotnet#96173
This was referenced Dec 19, 2023
Merged
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 26, 2023
@pavelsavara pavelsavara mentioned this issue Jan 14, 2024
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
1 participant
@pavelsavara