Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1 #81585

Closed
v-wenyuxu opened this issue Feb 3, 2023 · 3 comments · Fixed by #81725
Closed

Test failure System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1 #81585

v-wenyuxu opened this issue Feb 3, 2023 · 3 comments · Fixed by #81725
Assignees
@tannergooding
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes os-windows

Comments

@v-wenyuxu
Copy link

Run: runtime-coreclr libraries-jitstress 20230201.3

Failed test:

net8.0-windows-Release-x86-CoreCLR_checked-jitstress1-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-zapdisable-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-tailcallstress-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-tailcallstress-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-jitstress2-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-jitstress1-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-zapdisable-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-tailcallstress-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-jitstress2-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-no_tiered_compilation-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-zapdisable-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

Error message:

Assert.Equal() Failure
Expected: 0
Actual:   1


Stack trace
   at System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1() in /_/src/libraries/System.Numerics.Vectors/tests/Vector4Tests.cs:line 214
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59
@v-wenyuxu v-wenyuxu added os-windows JitStress CLR JIT issues involving JIT internal stress modes arch-x64 labels Feb 3, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 3, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2023
@ghost
Copy link

ghost commented Feb 3, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstress 20230201.3

Failed test:

net8.0-windows-Release-x86-CoreCLR_checked-jitstress1-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-zapdisable-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-tailcallstress-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-tailcallstress-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-jitstress2-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-jitstress1-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x64-CoreCLR_checked-zapdisable-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-tailcallstress-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-windows-Release-x86-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-jitstress2-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-no_tiered_compilation-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

net8.0-linux-Release-x64-CoreCLR_checked-zapdisable-Ubuntu.1804.Amd64.Open
- System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1

Error message:

Assert.Equal() Failure
Expected: 0
Actual:   1


Stack trace
   at System.Numerics.Tests.Vector4Tests.Vector4DistanceTest1() in /_/src/libraries/System.Numerics.Vectors/tests/Vector4Tests.cs:line 214
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59
Author: v-wenyuxu
Assignees: -
Labels:

os-windows, JitStress, arch-x64, area-CodeGen-coreclr, untriaged
Milestone: -

@kunalspathak
Copy link
Member

@tannergooding - related to #81335?

@kunalspathak kunalspathak removed the untriaged New issue has not been triaged by the area owner label Feb 3, 2023
@tannergooding
Copy link
Member

Yes, likely. Seems to be a case missed by the jitstress runs I did trigger.

@tannergooding tannergooding self-assigned this Feb 3, 2023
@tannergooding tannergooding mentioned this issue Feb 6, 2023
Merged
tannergooding added a commit to tannergooding/runtime that referenced this issue Feb 6, 2023
@tannergooding
Adding a regression test for dotnet#81585
22e79d8
@tannergooding tannergooding mentioned this issue Feb 6, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 6, 2023
tannergooding added a commit that referenced this issue Feb 7, 2023
@tannergooding
Fix a bug around Vector4.Distance and Sse41.Insert lowering (#81725)
32ea339 
* Adding a regression test for #81585

* Fixing a bug around Sse41.Insert lowering

* Ensure that Distance/DistanceSquared are correctly imported

* Account for another case around Sse41.Insert chain folding
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tannergooding tannergooding

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug around Vector4.Distance and Sse41.Insert lowering tannergooding/runtime
3 participants
@tannergooding @kunalspathak @v-wenyuxu