[wasm] allow the debug proxy to startup on a fixed port #65209
Comments
|
Tagging subscribers to this area: @thaystg Issue DetailsFor some development cases it would be preferable for the debug proxy to be able to start on fixed port, we should enable a mechanism to override the current dynamic port logic
|
dotnet-issue-labeler
bot
added
the
untriaged
radical
added a commit
to radical/runtime
that referenced
this issue
Feb 22, 2022
.. with `--proxy-port=<port>`. Fixes dotnet#65209 .
radical
added a commit
to radical/runtime
that referenced
this issue
Feb 23, 2022
.. with `--proxy-port=<port>`. Fixes dotnet#65209 .
radical
added a commit
that referenced
this issue
Feb 24, 2022
* [wasm][debugger] Fail test if an assertion is detected
* [wasm][debugger] Make DevToolsProxy's `pending_ops` thread-safe
Currently, `pending_ops` can get written by different threads at the
same time, and also read in parallel. This causes tests to randomly fail
with:
```
DevToolsProxy::Run: Exception System.ArgumentException: The tasks argument included a null value. (Parameter 'tasks')
at System.Threading.Tasks.Task.WhenAny(Task[] tasks)
at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.Run(Uri browserUri, WebSocket ideSocket) in /_/src/mono/wasm/debugger/BrowserDebugProxy/DevToolsProxy.cs:line 269
```
Instead, we use `Channel<T>` to add the ops, and then read those in
the main loop, and add to the *local* `pending_ops` list.
* [wasm] Install chrome for debugger tests
- controlled by `$(InstallChromeForDebuggerTests)` which defaults to
`true` for non-CI docker containers
- Useful for using the correct chrome version when testing locally, or
on codespaces
- Also, add support for detecting, and defaulting to such an
installation
* [wasm][debugger] Disable tests failing with runtime assertions
`DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsError`: #65744
`DebuggerTests.ArrayTests.InvalidArrayId`: #65742
* [wasm][debugger] Fix NRE with `"null"` condition for a breakpoint
`ConditionalBreakpoint` test fails.
The test with condition=`"null"` failed with a NRE, instead of correctly
handling it as a condition that returns null.
```
Unable evaluate conditional breakpoint: System.Exception: Internal Error: Unable to run (null ),
error: Object reference not set to an instance of an object..
---> System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.WebAssembly.Diagnostics.EvaluateExpression.CompileAndRunTheExpression(String expression, MemberReferenceResolver resolver, CancellationToken token) in /workspaces/runtime/src/mono/wasm/debugger/BrowserDebugProxy/EvaluateExpression.cs:line 399
--- End of inner exception stack trace ---
at Microsoft.WebAssembly.Diagnostics.EvaluateExpression.CompileAndRunTheExpression(String expression, MemberReferenceResolver resolver, CancellationToken token) in /workspaces/runtime/src/mono/wasm/debugger/BrowserDebugProxy/EvaluateExpression.cs:line 407
at Microsoft.WebAssembly.Diagnostics.MonoProxy.EvaluateCondition(SessionId sessionId, ExecutionContext context, Frame mono_frame, Breakpoint bp, CancellationToken token) in /workspaces/runtime/src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs:line 801 condition:null
```
* [wasm] Improve default message for ReturnAsErrorException,
.. since we seem to be not catching them as intended in many places.
* [wasm] Better log, and surface errors in evaluation conditional
.. breakpoints.
Catch the proper exception `ReturnAsErrorException`, so we can get the
actual error message. And log that as an error for the user too.
* [wasm][debugger] Allow setting proxy port for BrowserDebugHost
.. with `--proxy-port=<port>`.
Fixes #65209 .
* [wasm][debugger] Handle errors in getting value for locals
Essentially, catch, and skip.
* message cleanup
* remove trailing space
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For some development cases it would be preferable for the debug proxy to be able to start on fixed port, we should enable a mechanism to override the current dynamic port logic
The text was updated successfully, but these errors were encountered: