Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Linux/AOT tests(9) broken #62362

Closed
9 tasks
radical opened this issue Dec 3, 2021 · 5 comments
Closed
9 tasks

[wasm] Linux/AOT tests(9) broken #62362

radical opened this issue Dec 3, 2021 · 5 comments
Assignees
@vargaz
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue
Milestone
7.0.0

Comments

@radical
Copy link
Member

radical commented Dec 3, 2021 •
edited
Loading

The fix(#62339) for AOT on windows seems to have broken tests on linux. The PR ran only System.Runtime.Tests by default, so these slipped through.

Found on #62352

Build

[21:18:42] info: ./dotnet.js:8092: RuntimeError: function signature mismatch
[21:18:42] info:     if (e !== e+0 && e !== 'longjmp') throw e;
[21:18:42] info:                                       ^
[21:18:42] info: RuntimeError: function signature mismatch
[21:18:42] info:     at System_Collections_Immutable_System_Collections_Immutable_SortedInt32KeyNode_1_Enumerator_TValue_INST_MoveNext_0 (<anonymous>:wasm-function[12535]:0x343583)
[21:18:42] info:     at System_Collections_Immutable_System_Collections_Immutable_ImmutableDictionary_2_Enumerator_TKey_REF_TValue_REF_MoveNext (<anonymous>:wasm-function[11431]:0x302c17)
[21:18:42] info:     at ut_System_Collections_Immutable_System_Collections_Immutable_ImmutableDictionary_2_Enumerator_TKey_REF_TValue_REF_MoveNext (<anonymous>:wasm-function[11433]:0x302ee4)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Converters_DictionaryDefaultConverter_3_TDictionary_REF_TKey_REF_TValue_REF_OnWriteResume_System_Text_Json_Utf8JsonWriter_TDictionary_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88816]:0x13130b5)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonDictionaryConverter_3_TDictionary_REF_TKey_REF_TValue_REF_OnTryWrite_System_Text_Json_Utf8JsonWriter_TDictionary_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88302]:0x12f7cb5)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonConverter_1_T_REF_TryWrite_System_Text_Json_Utf8JsonWriter_T_REF__System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88362]:0x12f925e)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Metadata_JsonPropertyInfo_1_T_REF_GetMemberAndWriteJson_object_System_Text_Json_WriteStack__System_Text_Json_Utf8JsonWriter (<anonymous>:wasm-function[88614]:0x1304edf)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Converters_ObjectDefaultConverter_1_T_REF_OnTryWrite_System_Text_Json_Utf8JsonWriter_T_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88976]:0x132173d)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonConverter_1_T_REF_TryWrite_System_Text_Json_Utf8JsonWriter_T_REF__System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88362]:0x12f925e)
[21:18:42] info:     at System_Text_Json_Tests_aot_wrapper_gsharedvt_out_sig_u1_this_objbiiobjbii (<anonymous>:wasm-function[133311]:0x1cba97f)
[21:18:42] info:     at jit_call_cb (<anonymous>:wasm-function[158293]:0x21c5406)
...

21:06:42] fail: RuntimeError: function signature mismatch
[21:06:42] fail:     at System_Collections_Immutable_Tests_System_Collections_Immutable_ImmutableSortedSet_1_Enumerator_T_INT_MoveNext (<anonymous>:wasm-function[14188]:0x488649)
[21:06:42] fail:     at corlib_aot_wrapper_gsharedvt_out_sig_pinvoke_u1_this_ (<anonymous>:wasm-function[51282]:0xd273f7)
...

Others that might be similar with corlib_aot_wrapper_gsharedvt_out_* near the top frames:

Others, hit on #61581, build

cc @vargaz @radekdoulik
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Codegen-AOT-mono labels Dec 3, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The fix(#62339) for AOT on windows seems to have broken tests on linux. The PR ran only System.Runtime.Tests by default, so these slipped through.

Found on #62352

Build

  1. System.Collections.Immutable.Tests
21:06:42] fail: RuntimeError: function signature mismatch
[21:06:42] fail:     at System_Collections_Immutable_Tests_System_Collections_Immutable_ImmutableSortedSet_1_Enumerator_T_INT_MoveNext (<anonymous>:wasm-function[14188]:0x488649)
[21:06:42] fail:     at corlib_aot_wrapper_gsharedvt_out_sig_pinvoke_u1_this_ (<anonymous>:wasm-function[51282]:0xd273f7)
...

  1. Others that might be similar with corlib_aot_wrapper_gsharedvt_out_* near the top frames: System.ValueType.Tests, System.Linq.Parallel.Tests, System.Reflection.TypeExtensions.Tests, System.Text.Json.SourceGeneration.Roslyn3.11.Tests,

    • are broken with similar looking top (or near the top) frame ()

  2. System.Text.Json.Tests

[21:18:42] info: ./dotnet.js:8092: RuntimeError: function signature mismatch
[21:18:42] info:     if (e !== e+0 && e !== 'longjmp') throw e;
[21:18:42] info:                                       ^
[21:18:42] info: RuntimeError: function signature mismatch
[21:18:42] info:     at System_Collections_Immutable_System_Collections_Immutable_SortedInt32KeyNode_1_Enumerator_TValue_INST_MoveNext_0 (<anonymous>:wasm-function[12535]:0x343583)
[21:18:42] info:     at System_Collections_Immutable_System_Collections_Immutable_ImmutableDictionary_2_Enumerator_TKey_REF_TValue_REF_MoveNext (<anonymous>:wasm-function[11431]:0x302c17)
[21:18:42] info:     at ut_System_Collections_Immutable_System_Collections_Immutable_ImmutableDictionary_2_Enumerator_TKey_REF_TValue_REF_MoveNext (<anonymous>:wasm-function[11433]:0x302ee4)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Converters_DictionaryDefaultConverter_3_TDictionary_REF_TKey_REF_TValue_REF_OnWriteResume_System_Text_Json_Utf8JsonWriter_TDictionary_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88816]:0x13130b5)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonDictionaryConverter_3_TDictionary_REF_TKey_REF_TValue_REF_OnTryWrite_System_Text_Json_Utf8JsonWriter_TDictionary_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88302]:0x12f7cb5)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonConverter_1_T_REF_TryWrite_System_Text_Json_Utf8JsonWriter_T_REF__System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88362]:0x12f925e)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Metadata_JsonPropertyInfo_1_T_REF_GetMemberAndWriteJson_object_System_Text_Json_WriteStack__System_Text_Json_Utf8JsonWriter (<anonymous>:wasm-function[88614]:0x1304edf)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_Converters_ObjectDefaultConverter_1_T_REF_OnTryWrite_System_Text_Json_Utf8JsonWriter_T_REF_System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88976]:0x132173d)
[21:18:42] info:     at System_Text_Json_System_Text_Json_Serialization_JsonConverter_1_T_REF_TryWrite_System_Text_Json_Utf8JsonWriter_T_REF__System_Text_Json_JsonSerializerOptions_System_Text_Json_WriteStack_ (<anonymous>:wasm-function[88362]:0x12f925e)
[21:18:42] info:     at System_Text_Json_Tests_aot_wrapper_gsharedvt_out_sig_u1_this_objbiiobjbii (<anonymous>:wasm-function[133311]:0x1cba97f)
[21:18:42] info:     at jit_call_cb (<anonymous>:wasm-function[158293]:0x21c5406)
...

cc @vargaz @radekdoulik

Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-Codegen-AOT-mono
Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Dec 3, 2021
@lewing lewing added this to the .NET 7.0 milestone Dec 3, 2021
@lewing
Copy link
Member

lewing commented Dec 3, 2021

cc @vargaz @imhameed @lambdageek

@radical radical mentioned this issue Dec 3, 2021
Open
@runfoapp runfoapp bot mentioned this issue Dec 3, 2021
Closed
radical added a commit to radical/runtime that referenced this issue Dec 3, 2021
@radical
[wasm] Disable failing AOT tests
597b65e 
dotnet#62363
dotnet#62362
@agocke
Copy link
Member

agocke commented Dec 3, 2021

In order to run the full mono tests you need to run /azp run runtime-manual

@agocke agocke mentioned this issue Dec 3, 2021
Closed
radical added a commit to radical/runtime that referenced this issue Dec 4, 2021
@radical
[wasm] Disable failing AOT tests
18a06d3 
dotnet#62362
@radical radical mentioned this issue Dec 4, 2021
Merged
@lambdageek
Copy link
Member

In order to run the full mono tests you need to run /azp run runtime-manual

That's the intention, but at the moment it doesn't run everything. In particular, it doesn't run the runtime (src/tests) tests

@vargaz vargaz mentioned this issue Dec 4, 2021
Merged
@radical radical added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Dec 4, 2021
@karelz karelz modified the milestones: .NET 7.0, 7.0.0 Dec 6, 2021
@radical
Copy link
Member Author

radical commented Dec 7, 2021

Fixed by #62400 . The tests have been enabled, and passing on rolling builds.

@radical radical closed this as completed Dec 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vargaz vargaz

Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
6 participants
@radical @lewing @vargaz @lambdageek @agocke @karelz